Skip to content
This repository was archived by the owner on May 21, 2025. It is now read-only.

JBIDE-17153 : extra -vmarg for discovery urls are now unnecessary - #77

Closed
fbricon wants to merge 1 commit into
jbdevstudio:masterfrom
fbricon:JBIDE-17153
Closed

JBIDE-17153 : extra -vmarg for discovery urls are now unnecessary#77
fbricon wants to merge 1 commit into
jbdevstudio:masterfrom
fbricon:JBIDE-17153

Conversation

@fbricon

@fbricon fbricon commented May 16, 2014

Copy link
Copy Markdown
Contributor

Signed-off-by: Fred Bricon fbricon@gmail.com

Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon

fbricon commented May 16, 2014

Copy link
Copy Markdown
Contributor Author

new files basically have been s/Beta1/Beta2/g'ed

References to -Djboss.discovery.directory* have been removed

@mickaelistria

Copy link
Copy Markdown
Contributor

What's the replacement for these properties then?
What are the instruction to test a specific version of Central ?

@nickboldt

Copy link
Copy Markdown
Member

Even if the default value is now set correctly here [1], we still need to be able to override it for respins.

[1] http://download.jboss.org/jbosstools/configuration/ide-config.properties

{quote}
To test the upcoming version of Central, add this to your eclipse.ini file after the -vmargs line:
-Djboss.discovery.directory.url=http://download.jboss.org/jbosstools/discovery/development/${version}/jbosstools-directory.xml
-Djboss.discovery.site.url=http://download.jboss.org/jbosstools/discovery/development/${version}/
{quote}

@mmalina

mmalina commented May 19, 2014

Copy link
Copy Markdown

@nickboldt I thought that the idea is that the property file gets updated with the respin. But yeah, we probably still need a way to override, e.g. if we ever need to compare central in a "respin a" and a "respin b".

@fbricon

fbricon commented May 21, 2014

Copy link
Copy Markdown
Contributor Author

@nickboldt @mmalina the overriding mechanism still exists. However I don't see why we should still mention it in the template email. If a respin is done, then the proper url replaces the old one in http://download.jboss.org/jbosstools/configuration/ide-config.properties

@maxandersen

Copy link
Copy Markdown
Member

@nickboldt you can add your specific ones in the ide-config.properties for that exact respin.
The manual override is still possible but QE should not need to use these as all. Thats the whole point here. We can explicitly tell QE what to test since it will simply just happen automatically.

@nickboldt

Copy link
Copy Markdown
Member

Max: How do you propose that the specific respin maps to a specific URL? using the FQVS, including timestamp and BUILD_NUMBER?

Do you really want clutter in the file, like this?

jboss.discovery.directory.url|jbosstools|4.2.0.Beta2-v20140520-1347-B8823=http://download.jboss.org/jbosstools/discovery/development/4.2.0.Beta2b/jbosstools-directory.xml
jboss.discovery.site.url|jbosstools|4.2.0.Beta2-v20140520-1347-B8823=http://download.jboss.org/jbosstools/discovery/development/4.2.0.Beta2b/

@maxandersen

Copy link
Copy Markdown
Member

I dont see a need for putting that in the file, but yes if that is really needed then yes it would be good we have this option.

@fbricon

fbricon commented May 21, 2014

Copy link
Copy Markdown
Contributor Author

Well we currently can't use stuff like jboss.discovery.directory.url|jbosstools|4.2.0.Beta2-v20140520-1347-B8823 in the properties file because 4.2.0.Beta2-v20140520-1347-B8823 is not available as a maven property during the build (unless I'm wrong and then please enlighten me)

@mickaelistria

Copy link
Copy Markdown
Contributor

Unfortunaely, this change was applied although it totally screws up previous changes made by 3dfae28 . Some additional merge efforts are now necessary...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants