JBIDE-17153 : extra -vmarg for discovery urls are now unnecessary - #77
JBIDE-17153 : extra -vmarg for discovery urls are now unnecessary#77fbricon wants to merge 1 commit into
Conversation
Signed-off-by: Fred Bricon <fbricon@gmail.com>
|
new files basically have been s/Beta1/Beta2/g'ed References to -Djboss.discovery.directory* have been removed |
|
What's the replacement for these properties then? |
|
Even if the default value is now set correctly here [1], we still need to be able to override it for respins. [1] http://download.jboss.org/jbosstools/configuration/ide-config.properties {quote} |
|
@nickboldt I thought that the idea is that the property file gets updated with the respin. But yeah, we probably still need a way to override, e.g. if we ever need to compare central in a "respin a" and a "respin b". |
|
@nickboldt @mmalina the overriding mechanism still exists. However I don't see why we should still mention it in the template email. If a respin is done, then the proper url replaces the old one in http://download.jboss.org/jbosstools/configuration/ide-config.properties |
|
@nickboldt you can add your specific ones in the ide-config.properties for that exact respin. |
|
Max: How do you propose that the specific respin maps to a specific URL? using the FQVS, including timestamp and BUILD_NUMBER? Do you really want clutter in the file, like this? jboss.discovery.directory.url|jbosstools|4.2.0.Beta2-v20140520-1347-B8823=http://download.jboss.org/jbosstools/discovery/development/4.2.0.Beta2b/jbosstools-directory.xml |
|
I dont see a need for putting that in the file, but yes if that is really needed then yes it would be good we have this option. |
|
Well we currently can't use stuff like jboss.discovery.directory.url|jbosstools|4.2.0.Beta2-v20140520-1347-B8823 in the properties file because 4.2.0.Beta2-v20140520-1347-B8823 is not available as a maven property during the build (unless I'm wrong and then please enlighten me) |
|
Unfortunaely, this change was applied although it totally screws up previous changes made by 3dfae28 . Some additional merge efforts are now necessary... |
Signed-off-by: Fred Bricon fbricon@gmail.com