adjust_*_axis() limits doesn't seem to work with dates

[dsmccormick8492]

Very much enjoying exploring tidy plots, and looking forward to using it in my regular work.

I don't know if this has been implemented and I'm doing it wrong, but I have a data frame with a column of Date 's and another with some count. When I tried to use adjust_x_axis(limits = c(start_date, end_date)) the x axis is not restricted to between start_date and end_date. Example below. Note also that the padding and the x-axis annotation changes in the second case. The third case with add(xlim(start_date, end_date)) for the ggplot call works as I expected.

If this is not yet implemented, could dates be added to the limit criteria?

Thanks for this great work.

library(tidyplots)
library(patchwork)

dates <- seq(ymd('2024-01-01'), lubridate::today(), by='1 week')
vals <- rnorm(length(dates))
df <- tibble("date" = dates, "value" = vals)

p1 <- df |>
  tidyplot(x = date, y = value, height = NA, width = NA) |>
  add_data_points(color = "blue") 

start_date <- as_date("2025-01-01")
end_date <- lubridate::today()

p2 <- df |>
  tidyplot(x = date, y = value, height = NA, width = NA) |>
  add_data_points(color = "red") |>
  adjust_x_axis(limits = c(start_date, end_date))

p3 <- df |>
  tidyplot(x = date, y = value, height = NA, width = NA) |>
  add_data_points(color = "orchid") |>
  add(xlim(start_date, end_date))

p1 / p2 / p3

[jbengler]

Hi @dsmccormick8492

Thank you for using tidyplots and for spotting this bug!

I just pushed a fix to the development version of tidyplots. You can try it by installing the development version like so

install.packages("pak")
pak::pak("jbengler/tidyplots")

Sometimes pak is not working. In this case you can try

install.packages("devtools")
devtools::install_github("jbengler/tidyplots")

Best
Broder

[dsmccormick8492]

I did what you suggested and it works now. Thank you for addressing this. And thank you for your work on tidyplots.

[jbengler]

You are welcome! Thanks for spotting this!