Bump org.apache.activemq:artemis-jakarta-server from 2.24.0 to 2.44.0#532
Conversation
Bumps org.apache.activemq:artemis-jakarta-server from 2.24.0 to 2.44.0. --- updated-dependencies: - dependency-name: org.apache.activemq:artemis-jakarta-server dependency-version: 2.44.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
| <dependency> | ||
| <groupId>org.apache.activemq</groupId> | ||
| <artifactId>artemis-jakarta-server</artifactId> | ||
| <version>2.24.0</version> |
There was a problem hiding this comment.
Thanks @tomjenkinson for fixing it. Could you consider using the (inherited) version of artemis-jakarta-server defined in the narayana bom? see https://github.com/jbosstm/narayana/blob/f99f7fef34d08478ea563eb9d76ecf487b18b636/boms/main/pom.xml#L54
slf4j is also defined in bom-test: https://github.com/jbosstm/narayana/blob/f99f7fef34d08478ea563eb9d76ecf487b18b636/boms/test/pom.xml#L51
There was a problem hiding this comment.
Actually I can see the property is also defined here
Line 138 in bf1bd5e
There was a problem hiding this comment.
I agree with you, it would be better to use the test BOM for the quickstart I think. Although did we decide to move away from using our BOM and hence why we ended up having it in a different file. Do we push the test BOM to Nexus/Central? I wonder if we try to solve separate to this action and maybe more generally to review the quickstarts in general and how they get their dependency versions?
There was a problem hiding this comment.
it would be better to use the test BOM for the quickstart I think
I agree
Do we push the test BOM to Nexus/Central?
yes, bom-test is here: https://mvnrepository.com/artifact/org.jboss.narayana/test-dependency-management
I wonder if we try to solve separate to this action and maybe more generally to review the quickstarts in general and how they get their dependency versions?
+1 I am ok to open a JBTM and solve it in a separate PR. In that case I would approve this PR
There was a problem hiding this comment.
I can open the JBTM. I won't promise to solve it though :)
Happy to await your approval. I will get the JBTM started
There was a problem hiding this comment.
dependabot
bot
deleted the
dependabot/maven/org.apache.activemq-artemis-jakarta-server-2.44.0
branch
2 participants
Bumps org.apache.activemq:artemis-jakarta-server from 2.24.0 to 2.44.0.
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)