Skip to content
This repository was archived by the owner on Jul 25, 2020. It is now read-only.

JCLOUDS-332 Skips tests broken on windows #175

Closed
zack-shoylev wants to merge 1 commit into from
Closed

JCLOUDS-332 Skips tests broken on windows #175

zack-shoylev wants to merge 1 commit into from

Conversation

@zack-shoylev
Copy link
Contributor

@zack-shoylev zack-shoylev commented Oct 11, 2013

backport

@buildhive
Copy link

buildhive commented Oct 11, 2013

jclouds » jclouds #500 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@cloudbees-pull-request-builder
Copy link

cloudbees-pull-request-builder commented Oct 11, 2013

jclouds-java-7-pull-requests #759 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder
Copy link

cloudbees-pull-request-builder commented Oct 11, 2013

jclouds-pull-requests #297 FAILURE
Looks like there's a problem with this pull request

@demobox
Copy link
Member

demobox commented Oct 12, 2013

Failures are real - merge issue.

@zack-shoylev
Copy link
Contributor Author

zack-shoylev commented Oct 28, 2013

I think I figured it out. Will try to fix.

@demobox
Copy link
Member

demobox commented Oct 28, 2013

I think I figured it out. Will try to fix.

Thanks, @zack-shoylev!

@cloudbees-pull-request-builder
Copy link

cloudbees-pull-request-builder commented Oct 29, 2013

jclouds-pull-requests #356 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder
Copy link

cloudbees-pull-request-builder commented Oct 29, 2013

jclouds-java-7-pull-requests #819 SUCCESS
This pull request looks good

@buildhive
Copy link

buildhive commented Oct 29, 2013

jclouds » jclouds #565 SUCCESS
This pull request looks good
(what's this?)

demobox
demobox reviewed Oct 29, 2013
View reviewed changes
...tem/src/test/java/org/jclouds/filesystem/integration/FilesystemContainerIntegrationTest.java Outdated
Copy link
Member

@demobox demobox Oct 29, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[minor] Weird line split now? Back to two lines?

@demobox
Copy link
Member

demobox commented Oct 29, 2013

+1 for the code itself, only a couple of minor comments there. Main comment is whether we still need to restrict the input data for Windows if we're then also going to go and skip most of the tests..?

@demobox
Copy link
Member

demobox commented Oct 30, 2013

Thanks for answering my main question, @zack-shoylev! +1 - good to go for me!

@zack-shoylev
Copy link
Contributor Author

zack-shoylev commented Oct 30, 2013

Fixed the weird line split, will merge after tests pass, unless I get more comments.

@cloudbees-pull-request-builder
Copy link

cloudbees-pull-request-builder commented Oct 30, 2013

jclouds-java-7-pull-requests #820 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder
Copy link

cloudbees-pull-request-builder commented Oct 30, 2013

jclouds-pull-requests #357 SUCCESS
This pull request looks good

@buildhive
Copy link

buildhive commented Oct 30, 2013

jclouds » jclouds #566 SUCCESS
This pull request looks good
(what's this?)

@zack-shoylev
Copy link
Contributor Author

zack-shoylev commented Oct 30, 2013

merged

@demobox
Copy link
Member

demobox commented Oct 31, 2013

Thanks, @zack-shoylev!

@demobox demobox mentioned this pull request Nov 1, 2013
Closed
@zack-shoylev zack-shoylev deleted the skip-windows-tests-backport branch February 6, 2014 23:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zack-shoylev @buildhive @cloudbees-pull-request-builder @demobox