Address FindBugs issues and disable some detectors

[gaul]

This commit fixes enough FindBugs issues and disables enough detectors for mvn findbugs:check to pass.

[cloudbees-pull-request-builder]

jclouds-pull-requests-java-6 #30 SUCCESS
This pull request looks good

[buildhive]

jclouds » jclouds #1558 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

[cloudbees-pull-request-builder]

jclouds-pull-requests #1119 UNSTABLE
Looks like there's a problem with this pull request

[cloudbees-pull-request-builder]

jclouds-pull-requests-java-6 #31 SUCCESS
This pull request looks good

[cloudbees-pull-request-builder]

jclouds-pull-requests-java-6 #32 SUCCESS
This pull request looks good

[buildhive]

jclouds » jclouds #1559 SUCCESS
This pull request looks good
(what's this?)

[cloudbees-pull-request-builder]

jclouds-pull-requests #1120 UNSTABLE
Looks like there's a problem with this pull request

[cloudbees-pull-request-builder]

jclouds-pull-requests #1121 SUCCESS
This pull request looks good

[buildhive]

jclouds » jclouds #1560 SUCCESS
This pull request looks good
(what's this?)

[demobox]

I'm guessing the elements listed are also those included in the toString?

[gaul]

Correct. Note that some tests actually fail when I included credential and credentialUrl.

[demobox]

Thanks, @andrewgaul! One thing I noticed was that there are a couple of cases (I commented on two but didn't check further) where we are replacing X.valueOf with X.parseX even though the required value is actually the wrapper object (as returned by valueOf), not the primitive as returned by parseX.

Is there any benefit to doing so? Otherwise, it seems to me that using the parsing method that actually returns the required type, and not relying on autoboxing, would be more logical?

[gaul]

This pull request has two commented out sections that I do not know how to address and appreciate suggestions. If we cannot find a solution I will remove the changes and disable those detectors as well.

In terms of parseInt vs. valueOf, there former is always at least as efficient when the caller expects an Integer and slightly more efficient when the caller expects an int. We could add a Checkstyle regexp to prevent use of valueOf entirely.

[gaul]

I pushed the agreed-upon changes to master as 63d43f2, 5399cb6, 195998b, and fdef97d. I updated the pull request with the amended changes.

[cloudbees-pull-request-builder]

jclouds-pull-requests-java-6 #40 SUCCESS
This pull request looks good

[buildhive]

jclouds » jclouds #1573 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

[cloudbees-pull-request-builder]

jclouds-pull-requests #1129 ABORTED

[cloudbees-pull-request-builder]

jclouds-pull-requests-java-6 #47 SUCCESS
This pull request looks good