Skip to content
This repository was archived by the owner on Jul 25, 2020. It is now read-only.

metadata and content metadata should have the same length#751

Merged
1 commit merged intojclouds:masterfrom
kahing:fix-local-blobstore-range-get-size
May 27, 2015
Merged

metadata and content metadata should have the same length#751
1 commit merged intojclouds:masterfrom
kahing:fix-local-blobstore-range-get-size

Conversation

@kahing
Copy link
Copy Markdown
Contributor

@kahing kahing commented May 26, 2015

for range get in a LocalBlobStore, metadata.getSize() has the
original blob size and contentMetadata.getContentLength() has
the actual payload size. Other blobstores have the same size
in both

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should BaseBlobIntegrationTest.validateMetadata check metadata.getSize?

for range get in a LocalBlobStore, metadata.getSize() has the
original blob size and contentMetadata.getContentLength() has
the actual payload size. Other blobstores have the same size
in both
@kahing kahing force-pushed the fix-local-blobstore-range-get-size branch from a2c3b98 to bbafc34 Compare May 26, 2015 23:45
@ghost ghost merged commit bbafc34 into jclouds:master May 27, 2015
@gaul
Copy link
Copy Markdown
Member

gaul commented May 28, 2015

Jenkins shows failures of the form:

testPutObjectStream(org.jclouds.blobstore.integration.TransientBlobIntegrationTest)  Time elapsed: 0.006 sec  <<< FAILURE!
java.lang.AssertionError: expected [null] but found [3]
    at org.testng.Assert.fail(Assert.java:94)
    at org.testng.Assert.failNotEquals(Assert.java:494)
    at org.testng.Assert.assertEquals(Assert.java:123)
    at org.testng.Assert.assertEquals(Assert.java:165)
    at org.jclouds.blobstore.integration.internal.BaseBlobStoreIntegrationTest.validateMetadata(BaseBlobStoreIntegrationTest.java:287)
    at org.jclouds.blobstore.integration.internal.BaseBlobIntegrationTest.testPutObjectStream(BaseBlobIntegrationTest.java:577)

@gaul
Copy link
Copy Markdown
Member

gaul commented May 28, 2015

Reverted in f19853c.

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants