fix: stop hanging on cyclic exception __cause__ chains - #660
Merged
mergify[bot] merged 1 commit intoJul 29, 2026
Conversation
retry_if_exception_cause_type walked __cause__ until None. Legal cycles such as ``raise e from e`` (or mutual a<->b causes) never terminate, so the predicate spins at 100% CPU and stop conditions never run. Track seen exception ids while walking, matching stdlib traceback's cycle-safe approach. Regression covers self-cause and two-node cycles. Fixes jd#658.
jd
approved these changes
Jul 29, 2026
Contributor
Merge Queue Status
This pull request spent 8 seconds in the queue, including 1 second running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #658.
retry_if_exception_cause_typewalked__cause__untilNone. A cyclic cause chain never ends, so the predicate spins at 100% CPU and stop conditions never run (they are only checked after the predicate returns).This is legal Python:
Two-node cycles (
a.__cause__ = b; b.__cause__ = a) hang the same way.Fix
Track
id(exc)while walking and stop when a cycle is detected — the same idea as the stdlibtracebackmodule’s cycle-safe chain walk.Tests
raise e from e)Checklist
pytest -k exception_causegreen