chore(mypy): enable the strictness options strict leaves off - #678
Merged
mergify[bot] merged 3 commits intoAug 5, 2026
Conversation
This was referenced Aug 5, 2026
Owner
Author
|
This pull request is part of a Mergify stack:
|
This was referenced Aug 5, 2026
jd
marked this pull request as ready for review
August 5, 2026 15:24
`on.pull_request.branches` filters on the *base* branch, not the head. With it pinned to `main`, only a pull request merging directly into `main` ran CI -- every stacked pull request, whose base is the branch below it in the stack, got no test, lint or mypy run at all and showed nothing but the Mergify checks. Drop the filter so CI runs for every pull request regardless of base. Change-Id: I1c211a106a57b9f4986bec4b76c0680c1a0f1b61
`__radd__` was annotated `other: wait_base`, which is the one type it can never receive: `wait_base.__add__` always succeeds, so Python never falls back to the reflected operator for two wait strategies. The only caller is `sum()`, which seeds its accumulator with the int 0 — hence the `type: ignore[comparison-overlap]` on `other == 0`, and the dead `return self` branch behind it that `--warn-unreachable` flags. Annotate the parameter as `int` and return `NotImplemented` for a non-zero left operand, so `5 + wait_fixed(1)` raises `TypeError` at the addition rather than building a `wait_combine` that explodes later when called. With the signature corrected, mypy infers `sum([...])` over wait strategies on its own, so four `type: ignore[list-item]` comments in `test_wait_arbitrary_sum` are no longer needed. Change-Id: Iad1bcef4412d6afc1a6f1335970cfbfcc4a34fcb
`strict = true` is a curated subset, not every check mypy has. These five error codes and three flags are all off under `strict` and all report zero errors on the current tree, so turning them on costs nothing today and catches regressions from here on: - `warn_unreachable` -- dead branches, which are usually a wrong annotation rather than dead code (see the `wait_base.__radd__` fix below this commit) - `disallow_any_unimported` -- silent `Any` leaking in from untyped deps - `extra_checks` -- unsafely overlapping operator signatures, among others - `ignore-without-code` -- keeps `type: ignore` comments specific - `redundant-expr`, `truthy-iterable`, `unused-awaitable`, `exhaustive-match` Deliberately left off: `disallow_any_expr` (655 errors -- unusable for a decorator library) and `disallow_any_decorated` (63 errors, all inherent to `@retry` wrapping untyped test helpers). Change-Id: I9eee43a749050d2bcf0aa0abbedf8725301eba18
jd
force-pushed
the
devs/jd/chore/mypy-strictness/annotate-wait-base-radd-taking-int-seed-sum--ad1bcef4
branch
from
August 5, 2026 15:39
b02c344 to
ae08acf
Compare
jd
force-pushed
the
devs/jd/chore/mypy-strictness/enable-strictness-options-strict-leaves-off--9eee43a7
branch
from
August 5, 2026 15:39
5a33f88 to
1897498
Compare
Owner
Author
Revision history
|
Contributor
Merge Queue Status
This pull request spent 1 minute 38 seconds in the queue, including 20 seconds running CI. Required conditions to merge
|
This was referenced Aug 5, 2026
Base automatically changed from
devs/jd/chore/mypy-strictness/annotate-wait-base-radd-taking-int-seed-sum--ad1bcef4
to
main
August 5, 2026 15:42
This was referenced Aug 5, 2026
mergify
Bot
deleted the
devs/jd/chore/mypy-strictness/enable-strictness-options-strict-leaves-off--9eee43a7
branch
August 5, 2026 15:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strict = trueis a curated subset, not every check mypy has. These fiveerror codes and three flags are all off under
strictand all report zeroerrors on the current tree, so turning them on costs nothing today and
catches regressions from here on:
warn_unreachable-- dead branches, which are usually a wrong annotationrather than dead code (see the
wait_base.__radd__fix below this commit)disallow_any_unimported-- silentAnyleaking in from untyped depsextra_checks-- unsafely overlapping operator signatures, among othersignore-without-code-- keepstype: ignorecomments specificredundant-expr,truthy-iterable,unused-awaitable,exhaustive-matchDeliberately left off:
disallow_any_expr(655 errors -- unusable for adecorator library) and
disallow_any_decorated(63 errors, all inherent to@retrywrapping untyped test helpers).Depends-On: #677