Satriyo/merge valhalla 83 - #109
Merged
Merged
Conversation
… + data scripts (#83) Merges ben/valhalla-local-sf (945 lines, 16 files): routing/valhalla_client.py (184 lines) - Local Valhalla CLI wrapper: decode polyline6, parse route shape into GeoJSON LineString, extract waypoints + summary - Force-local flag: raises if VALHALLA_FORCE_REMOTE set (security gate) atak/bridge.py + atak/cot.py (169 lines) - plan_to_kml(): serialize PlanResponse route as KML placemark - write_plan_kml(): write KML to output/routes/<uid>.kml - Rejects non-LineString and degenerate single-coord routes data/ (380 lines across 8 scripts + README + aois.yml) - fetch_osm.sh, fetch_dem.sh, clip_osm.sh, build_dem.sh - fetch_all.sh orchestrator + write_manifest.sh + verify_manifest.sh - data/aois.yml: SF + austere AO bounding boxes - data/README.md: usage + pre-flight instructions tests/ (178 lines) - test_valhalla_client.py: 4 tests (polyline decode, GeoJSON parse, missing shape rejection, CLI invocation) - test_atak_cot.py: 4 tests (KML export, directory creation, non-LineString rejection, single-coord rejection) All 8 tests pass. Zero merge conflicts with main. Closes #83 Closes #7 Closes #8 Closes #9
aleens-labs
requested review from
benschwierking,
jdev-02,
khicks1724 and
kylemhicks
as code owners
May 3, 2026 08:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ben/valhalla-local-sfinto main (zero conflicts)routing/valhalla_client.py— async Valhalla HTTP client with polyline6 decode → GeoJSON LineStringatak/bridge.py— bridges Valhalla route output to ATAK formatatak/cot.py— CoT (Cursor on Target) XML builder for ATAK route exportpytest tests/ routing/ -q)Closes
Closes #83
Closes #7
Closes #8
Closes #9
Test plan
pytest tests/ routing/ -q— 8/8 passedruff check .)