--filter <pkg> add drops foreign-platform optional deps from pnpm lockfiles while plain install keeps them (1.34.0)

[mwolson]

On a pnpm workspace whose supportedArchitectures lists include current, aube --filter <pkg> add removes every foreign-platform optional dependency from pnpm-lock.yaml. A plain aube install on the same workspace keeps them.

Both commands are aube 1.34.0, so this looks like an inconsistency between two code paths rather than a platform-filtering policy:

Command	Foreign-platform @esbuild/* entries in the lockfile
pnpm install (11.17.0, baseline)	45
pnpm --filter app add is-odd	45
aube install	45
aube --filter app add is-odd	0

On 1.32.0 the plain install also pruned, partially (45 to 21), so something already improved between 1.32 and 1.34. The filtered add path looks like it was missed.

Why it is easy to miss

current resolves per-machine, so a lockfile written on Linux loses every darwin and win32 entry and nothing on the authoring machine looks wrong. The failure lands on whoever installs next on another platform, and it is silent rather than loud: installing the pruned lockfile while targeting darwin succeeds and places @esbuild/linux-x64 with no darwin binary, because the entry that platform needs is no longer in the file to be chosen.

$ pnpm install --frozen-lockfile --ignore-scripts \
    --config.supportedArchitectures.os=darwin \
    --config.supportedArchitectures.cpu=arm64
Done in 126ms

$ ls node_modules/.pnpm | grep esbuild
esbuild@0.25.12
@esbuild+linux-x64@0.25.12      # no darwin binary

Repro

https://github.com/mwolson/tmp-aube-issues/tree/main/pnpm-filter-add-prunes-platform-optionals

repro.sh installs a baseline with native pnpm, runs the same filtered add through both tools, and compares. It exits 1 on the bug and 2 on environment problems, and refuses to run if PNPM_BIN resolves to a shim rather than a real pnpm.

AUBE_BIN=aube PNPM_BIN=/path/to/real/pnpm ./repro.sh

The workspace is one package depending on esbuild@0.25.12, plus:

supportedArchitectures:
  cpu: [current, x64]
  libc: [current, glibc]
  os: [current, linux]

Relationship to #938

#938 reported this class of problem for package-lock.json, and #942 fixed npm lockfile writes to record foreign optional natives. That shipped before 1.32.0. This is the pnpm lockfile path, which the change did not cover.

supportedArchitectures was the workaround recommended in #938. It is set in this workspace and does not prevent the prune, which is what makes the filtered-add behavior look like a bug rather than the documented host-only default.

Versions

• aube 1.34.0 linux-x64 (2026-07-27), also reproduced on 1.32.0
• pnpm 11.17.0 as the control
• Linux x64, glibc

Not tested

Whether an explicit os: [linux, darwin] with no current also prunes. That would distinguish "current resolution" from "filtered-add re-resolution" as the trigger.

[jdx]

Thanks for the detailed repro. I confirmed the root cause: the shared resolver narrowed portable-lockfile resolution whenever supportedArchitectures was configured, so any re-resolution path could discard optional packages for other platforms. Plain install often hid it by taking the fresh-lockfile path without rewriting the lockfile.

PR #1156 fixes this by keeping portable lockfile resolution in accept_all mode while continuing to apply supportedArchitectures during fetch/link filtering. With the supplied esbuild repro, the filtered add now retains all 45 foreign-platform entries; the lockfile diff contains only is-odd and its dependency.

#1156

This comment was generated by Codex.

[mwolson]

Confirmed fixed on aube 1.36.0 (fix shipped in 1.35.0 via #1156).

Retested the minimal repro at https://github.com/mwolson/tmp-aube-issues/tree/main/pnpm-filter-add-prunes-platform-optionals: aube --filter app add now keeps all 45 foreign-platform @esbuild/* lockfile entries (same count as the native pnpm baseline); the lockfile diff is only is-odd and its dependency. The same repro still fails on 1.34.0 (45 → 0).

Marking the fix reply as the answer; leaving the discussion open for searchability.