Migrate test terminal emulator from vt100 to rio-vt - #198
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughUnix test terminal emulation migrated from ChangesTerminal parser migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
||
| [target.'cfg(unix)'.dev-dependencies] | ||
| portable-pty = "0.9" | ||
| rio-vt = "0.5.1" |
Greptile SummaryMigrates Unix redraw-test terminal emulation from
Confidence Score: 3/5The PR is not safe to merge until the The manifest still declares Files Needing Attention: Cargo.toml Important Files Changed
Reviews (2): Last reviewed commit: "sort test imports for rustfmt" | Re-trigger Greptile |
|
Pushed a fix. For the record, the Greptile note about |
Swaps the redraw tests' terminal emulator from vt100 to rio-vt, Rio's terminal engine, behind a tiny
Parseradapter insrc/test.rsthat keeps the sameprocess/screen().contents()/screen().cursor_position()shape. The call sites inmultiselect.rs/select.rsare unchanged apart from the type name, and the full test suite passes (the cursor-drift and frame-shrink redraw assertions hold identically).rio-vtis a safe-Rust, dependency-light terminal core (VT state machine, grid, parser) and is actively maintained — the swap also drops the transitivenet2(RUSTSEC-2020-0016) that older terminal parsers pull in.Summary by CodeRabbit
ParserwithScreenassertions.