fix(env): add fnox artifact to ci path - #650
Conversation
|
Warning Review limit reached
Next review available in: 16 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryAdds the downloaded debug artifact directory to GitHub Actions PATH in both jobs that consume the fnox build artifact.
Confidence Score: 5/5The PR appears safe to merge, with both artifact-consuming jobs consistently exposing the downloaded fnox binary to subsequent steps. The artifact remains at target/debug/fnox, retains executable permissions, and its containing directory is added to PATH using the standard GitHub Actions environment-file mechanism. Important Files Changed
Reviews (1): Last reviewed commit: "fix(env): add fnox artifact to ci path" | Re-trigger Greptile |
Summary
target/debugdirectory to subsequent GitHub Actions steps viaGITHUB_PATHRoot cause
jdx/mise-actionv4.2.1 no longer exports thePATHreturned bymise env. The CI workflow implicitly relied on that behavior to exposetarget/debug/fnox, causing theci-otherjobs to fail withfnox: command not foundafter the action update.Validation
mise exec -- actionlint .github/workflows/ci.ymlmise run lintThis unblocks #633.
This pull request was generated by Codex.
Note
Low Risk
Workflow-only change with no application or secret-handling logic changes; low blast radius beyond CI reliability.
Overview
Restores
fnoxon PATH in theci-batsandci-otherjobs after the build artifact is downloaded. The old step only ranchmod +x target/debug/fnox; it now also appends$GITHUB_WORKSPACE/target/debugtoGITHUB_PATHso later steps can invokefnoxby name (e.g.fnox ci-redact, bats).This replaces implicit PATH setup from
mise-action(no longer exportingmise envPATH in v4.2.1), which had causedfnox: command not foundfailures.Reviewed by Cursor Bugbot for commit 4f91578. Bugbot is set up for automated code reviews on this repo. Configure here.