Skip to content

fix(env): add fnox artifact to ci path - #650

Merged
jdx merged 1 commit into
mainfrom
codex/fix-ci-mise-path
Jul 24, 2026
Merged

fix(env): add fnox artifact to ci path#650
jdx merged 1 commit into
mainfrom
codex/fix-ci-mise-path

Conversation

@jdx

@jdx jdx commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • add the downloaded target/debug directory to subsequent GitHub Actions steps via GITHUB_PATH
  • apply the explicit PATH setup to both jobs that consume the fnox build artifact

Root cause

jdx/mise-action v4.2.1 no longer exports the PATH returned by mise env. The CI workflow implicitly relied on that behavior to expose target/debug/fnox, causing the ci-other jobs to fail with fnox: command not found after the action update.

Validation

  • mise exec -- actionlint .github/workflows/ci.yml
  • mise run lint

This unblocks #633.

This pull request was generated by Codex.


Note

Low Risk
Workflow-only change with no application or secret-handling logic changes; low blast radius beyond CI reliability.

Overview
Restores fnox on PATH in the ci-bats and ci-other jobs after the build artifact is downloaded. The old step only ran chmod +x target/debug/fnox; it now also appends $GITHUB_WORKSPACE/target/debug to GITHUB_PATH so later steps can invoke fnox by name (e.g. fnox ci-redact, bats).

This replaces implicit PATH setup from mise-action (no longer exporting mise env PATH in v4.2.1), which had caused fnox: command not found failures.

Reviewed by Cursor Bugbot for commit 4f91578. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jdx, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 16 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: f7e03858-695f-464b-bf9f-d6fd5a53777f

📥 Commits

Reviewing files that changed from the base of the PR and between 0eb5142 and 4f91578.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jdx
jdx enabled auto-merge (squash) July 24, 2026 17:39
@greptile-apps

greptile-apps Bot commented Jul 24, 2026

Copy link
Copy Markdown

Greptile Summary

Adds the downloaded debug artifact directory to GitHub Actions PATH in both jobs that consume the fnox build artifact.

  • Keeps the downloaded fnox binary executable.
  • Exposes target/debug/fnox to subsequent CI steps on Linux and macOS.

Confidence Score: 5/5

The PR appears safe to merge, with both artifact-consuming jobs consistently exposing the downloaded fnox binary to subsequent steps.

The artifact remains at target/debug/fnox, retains executable permissions, and its containing directory is added to PATH using the standard GitHub Actions environment-file mechanism.

Important Files Changed

Filename Overview
.github/workflows/ci.yml Correctly appends the artifact download directory to GITHUB_PATH in both consuming jobs without changing artifact layout or job behavior.

Reviews (1): Last reviewed commit: "fix(env): add fnox artifact to ci path" | Re-trigger Greptile

@jdx
jdx merged commit 95a5322 into main Jul 24, 2026
16 checks passed
@jdx
jdx deleted the codex/fix-ci-mise-path branch July 24, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant