ci: build perf binaries on bamboo - #674
Conversation
📝 WalkthroughWalkthroughThe performance workflows no longer restore Rust build artifacts from caches. Comments state that compilation occurs inside the disposable measurement VM to avoid binaries built on a different runner class. ChangesPerformance workflow compilation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryRemoves Rust artifact caching from performance workflows so benchmark binaries are compiled on their disposable Bamboo runners.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "Merge branch 'main' into agent/bamboo-pe..." | Re-trigger Greptile |
Instruction counts
No instruction-count regression above 1.25%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.
|
### 🚀 Features - **(bitwarden)** support custom fields by [@jdx](https://github.com/jdx) in [#690](#690) ### 🐛 Bug Fixes - **(bitwarden)** support slashes in custom fields by [@jdx](https://github.com/jdx) in [#693](#693) - **(ci)** update Infisical project bootstrap by [@jdx](https://github.com/jdx) in [#675](#675) ### 📚 Documentation - **(sync)** clarify personal age provider setup by [@jdx](https://github.com/jdx) in [#692](#692) ### 🔍 Other Changes - run perf jobs on bamboo by [@jdx](https://github.com/jdx) in [#672](#672) - build perf binaries on bamboo by [@jdx](https://github.com/jdx) in [#674](#674) ### 📦️ Dependency Updates - update jdx/mise-action action to v4.2.3 by [@renovate[bot]](https://github.com/renovate[bot]) in [#677](#677) - update rust crate keepass to v0.13.18 by [@renovate[bot]](https://github.com/renovate[bot]) in [#678](#678) - update rust crate schemars to v1.2.2 by [@renovate[bot]](https://github.com/renovate[bot]) in [#679](#679) - update dependency github:jdx/tak to v0.0.5 by [@renovate[bot]](https://github.com/renovate[bot]) in [#676](#676) - update rust crate jsonwebtoken to v11 by [@renovate[bot]](https://github.com/renovate[bot]) in [#685](#685) - update zizmorcore/zizmor-action action to v0.6.1 by [@renovate[bot]](https://github.com/renovate[bot]) in [#680](#680) - update rust crate base64 to 0.23 by [@renovate[bot]](https://github.com/renovate[bot]) in [#683](#683) - update rust crate usage-lib to v4.1.0 by [@renovate[bot]](https://github.com/renovate[bot]) in [#684](#684) - update dependency @anthropic-ai/claude-code to v2.1.220 by [@renovate[bot]](https://github.com/renovate[bot]) in [#681](#681) - update rust crate usage-lib to v5 by [@renovate[bot]](https://github.com/renovate[bot]) in [#687](#687) - update rust crate rmcp to v3 by [@renovate[bot]](https://github.com/renovate[bot]) in [#688](#688)
Summary
target/built on Namespace from being measured and labeled as BambooValidation
actionlinton the affected performance workflowsgit diff --checkGenerated with AI assistance and manually validated.
Note
Low Risk
Workflow-only change affecting build caching for perf jobs; no application, auth, or data-path changes.
Overview
Perf CI (
perf.yml,perf-pr.yml) no longer restorestarget/viaSwatinem/rust-cache. Benchmark binaries are built from scratch on each disposablebamboo-perfrun so instruction counts are not attributed to Bamboo when artifacts were produced on another runner class (e.g. Namespace).Inline comments were added next to the
mise-actionstep to document that requirement. Regular CI workflows still userust-cache; only the tak measurement paths changed.Reviewed by Cursor Bugbot for commit e9ff3de. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit