ci: back mbx with the GitHub Actions cache alone - #69
Conversation
The remote cache server is retiring from CI: every job now uses the GitHub Actions cache backend, trusted and untrusted alike. The backend selection expression, the mbx-backend plumbing, the fork-PR cache mirror, and the server-warming workflow all existed to route trusted builds at https://cache.mise.jdx.dev, so they leave with it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe mbx composite action now always uses the GitHub Actions cache backend. CI workflow inputs and job invocations no longer select a backend or configure GitHub cache mirroring. Changesmbx Cache Consolidation
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThe PR retires the remote mbx cache server and standardizes CI on the GitHub Actions cache backend.
Confidence Score: 5/5The PR appears safe to merge, with the removed workflow inputs consistently eliminated from all in-repository callers. The trusted and untrusted CI paths now invoke the same GitHub cache backend, and no stale input references, incompatible workflow callers, or concrete cache initialization failures remain. Important Files Changed
Reviews (1): Last reviewed commit: "ci: back mbx with the GitHub Actions cac..." | Re-trigger Greptile |
v1.0.1 carries the fixes from jdx/packslip#63 and #65, along with the new download input from #69 (not adopted here -- this workflow already assembles release archives from an internal workflow artifact rather than gh release download, so download would not remove a step).
Retires the remote cache server from CI: every job now uses mbx's GitHub Actions cache backend. Removes the backend-selection expression, the
mbx-backendworkflow plumbing, the fork-PR cache mirror, and the server-warming workflow — all of which existed to route trusted builds at cache.mise.jdx.dev. mbx itself stays.id-token: writegrants are left in place where they may serve Pages deploys or attestations; they can be tightened separately.🤖 Generated with Claude Code
Note
Low Risk
Workflow-only change to build caching; no app logic, though trusted CI may see slower or colder caches without the remote server.
Overview
CI now routes all mbx setup through the GitHub Actions cache backend, dropping the trusted/untrusted split that pointed maintainer builds at
cache.mise.jdx.dev.The composite
.github/actions/mbxaction is simplified:backendandmirror-github-cacheinputs, the fork-PR cache mirror step, andserver-url/ OIDC settings are removed;backend: githubis fixed onmr-boxington-action.ci-impl.ymlno longer accepts or forwardsmbx-backend, and jobs call mbx without mirror flags.ci.ymlstops passingmbx-backend: servervsgithubinto the trusted and untrusted workflow paths.Reviewed by Cursor Bugbot for commit fb965fd. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit