Skip to content

ci: back mbx with the GitHub Actions cache alone - #69

Merged
jdx merged 1 commit into
mainfrom
ci/mbx-github-backend
Aug 29, 2026
Merged

ci: back mbx with the GitHub Actions cache alone#69
jdx merged 1 commit into
mainfrom
ci/mbx-github-backend

Conversation

@jdx

@jdx jdx commented Aug 29, 2026

Copy link
Copy Markdown
Owner

Retires the remote cache server from CI: every job now uses mbx's GitHub Actions cache backend. Removes the backend-selection expression, the mbx-backend workflow plumbing, the fork-PR cache mirror, and the server-warming workflow — all of which existed to route trusted builds at cache.mise.jdx.dev. mbx itself stays.

id-token: write grants are left in place where they may serve Pages deploys or attestations; they can be tightened separately.

🤖 Generated with Claude Code


Note

Low Risk
Workflow-only change to build caching; no app logic, though trusted CI may see slower or colder caches without the remote server.

Overview
CI now routes all mbx setup through the GitHub Actions cache backend, dropping the trusted/untrusted split that pointed maintainer builds at cache.mise.jdx.dev.

The composite .github/actions/mbx action is simplified: backend and mirror-github-cache inputs, the fork-PR cache mirror step, and server-url / OIDC settings are removed; backend: github is fixed on mr-boxington-action.

ci-impl.yml no longer accepts or forwards mbx-backend, and jobs call mbx without mirror flags. ci.yml stops passing mbx-backend: server vs github into the trusted and untrusted workflow paths.

Reviewed by Cursor Bugbot for commit fb965fd. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Refactor
    • Standardized build caching on the GitHub Actions cache backend.
    • Removed configurable cache backend and cache mirroring options.
    • Simplified continuous integration workflows by eliminating backend configuration inputs.

The remote cache server is retiring from CI: every job now uses the
GitHub Actions cache backend, trusted and untrusted alike. The backend
selection expression, the mbx-backend plumbing, the fork-PR cache
mirror, and the server-warming workflow all existed to route trusted
builds at https://cache.mise.jdx.dev, so they leave with it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@jdx
jdx merged commit 0cd1518 into main Aug 29, 2026
@jdx
jdx deleted the ci/mbx-github-backend branch August 29, 2026 01:54
@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: d1109a06-daf0-4ff7-94b4-cfb4a9e6aa6a

📥 Commits

Reviewing files that changed from the base of the PR and between 37bde07 and fb965fd.

📒 Files selected for processing (3)
  • .github/actions/mbx/action.yml
  • .github/workflows/ci-impl.yml
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

The mbx composite action now always uses the GitHub Actions cache backend. CI workflow inputs and job invocations no longer select a backend or configure GitHub cache mirroring.

Changes

mbx Cache Consolidation

Layer / File(s) Summary
Standardize the mbx action
.github/actions/mbx/action.yml
The action uses backend: github with jdx/mr-boxington-action version 0.6.0. It removes server configuration, backend selection, and cache mirroring.
Update CI workflow wiring
.github/workflows/ci-impl.yml, .github/workflows/ci.yml
The reusable workflow removes mbx-backend. Trusted and untrusted jobs no longer pass backend values. Local mbx invocations no longer pass backend or mirroring settings.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

A rabbit checks the cache with care
GitHub’s backend waits in there
Old server flags hop away
CI runs a simpler way
Clean workflows greet the day


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Aug 29, 2026

Copy link
Copy Markdown

Greptile Summary

The PR retires the remote mbx cache server and standardizes CI on the GitHub Actions cache backend.

  • Hardcodes the composite mbx action to use the GitHub backend.
  • Removes backend-selection and cache-mirroring inputs.
  • Simplifies the reusable CI workflow and both trusted and untrusted callers.

Confidence Score: 5/5

The PR appears safe to merge, with the removed workflow inputs consistently eliminated from all in-repository callers.

The trusted and untrusted CI paths now invoke the same GitHub cache backend, and no stale input references, incompatible workflow callers, or concrete cache initialization failures remain.

Important Files Changed

Filename Overview
.github/actions/mbx/action.yml Replaces conditional server/GitHub backend selection and explicit mirroring with one pinned action invocation using the GitHub backend.
.github/workflows/ci-impl.yml Removes the reusable backend input and obsolete arguments from all three mbx setup steps without leaving stale references.
.github/workflows/ci.yml Removes backend arguments from both reusable-workflow callers while preserving their trust and permission boundaries.

Reviews (1): Last reviewed commit: "ci: back mbx with the GitHub Actions cac..." | Re-trigger Greptile

jdx added a commit that referenced this pull request Sep 5, 2026
v1.0.1 carries the fixes from jdx/packslip#63 and #65, along with the
new download input from #69 (not adopted here -- this workflow already
assembles release archives from an internal workflow artifact rather
than gh release download, so download would not remove a step).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant