ci: restore rust-cache - #1371
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe workflows remove the mbx action and cache integration. Performance jobs use direct Cargo builds. Test jobs use Changesmbx integration removal
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change removes mbx from CI caching and performance builds while retaining trusted Rust cache writes for main-branch workflows. The supplied validation and workflow updates indicate no current merge-blocking production or user-impact risk. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes. Shadow comparisonParsing
|
Restores Swatinem/rust-cache for GitHub Actions while keeping mbx installed and the Cargo wrapper enabled for local development.
GitHub workflows set MBX_DISABLE=1, so Actions bypass mbx and rely on rust-cache. Cache writes are restricted to trusted pushes on supported main, release, or tag refs; pull requests, including forks, restore only. hk remains the dedicated GitHub Actions test bed for mbx.
Validation:
Summary by CodeRabbit