Skip to content

chore: bypass mbx for universal macos release builds - #1385

Merged
jdx merged 1 commit into
mainfrom
codex/fix-universal-macos-build
Sep 5, 2026
Merged

chore: bypass mbx for universal macos release builds#1385
jdx merged 1 commit into
mainfrom
codex/fix-universal-macos-build

Conversation

@jdx

@jdx jdx commented Sep 5, 2026

Copy link
Copy Markdown
Owner

The universal macOS release build passes both Apple targets to Cargo in one invocation. mbx 1.8.1 rejects this with managed linker selection supports one Cargo --target per invocation, causing the release build to fail before compilation.

Set MBX_DISABLE for the universal target so the Cargo shim passes through to native Cargo. Other matrix targets retain mbx.

Validation: actionlint, Prettier, and git diff --check pass. Verified the bypass behavior in mbx 1.8.1 source; the full signed release build was not run locally.

Fixes the failure in https://github.com/jdx/usage/actions/runs/33987850906/job/101364811217.


Note

Low Risk
CI-only conditional env var for one matrix target; no runtime or application code changes.

Overview
Fixes universal macOS release builds that fail when mbx rejects Cargo invocations with more than one --target (the universal apple-darwin path passes both architectures in a single build).

The publish-cli workflow now sets MBX_DISABLE only for the universal-apple-darwin matrix entry so the Cargo shim falls through to native Cargo for that job. All other release targets keep mbx enabled.

Reviewed by Cursor Bugbot for commit ef315d9. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed universal Apple Darwin builds by preventing conflicting target processing during packaging.
    • Other build targets continue to use the existing packaging behavior.

Entire-Checkpoint: 01M1SJ217CHC0QCDKNRHPE9PMK
@jdx
jdx merged commit 6e1add0 into main Sep 5, 2026
9 of 10 checks passed
@jdx
jdx deleted the codex/fix-universal-macos-build branch September 5, 2026 19:52
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Team

Run ID: 80b6b3ac-5805-43be-b01c-00b11711e7cb

📥 Commits

Reviewing files that changed from the base of the PR and between edabe42 and ef315d9.

📒 Files selected for processing (1)
  • .github/workflows/publish-cli.yml

📝 Walkthrough

Walkthrough

The publish workflow now sets MBX_DISABLE for universal-apple-darwin builds. Other matrix targets keep mbx enabled.

Changes

CLI publish workflow

Layer / File(s) Summary
Universal Darwin mbx configuration
.github/workflows/publish-cli.yml
The workflow disables mbx for universal-apple-darwin targets. Other targets do not set this flag.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

I am a rabbit beside the build,
Universal apples are neatly filled.
mbx rests when two targets align,
Other builds proceed by design.
The publish path hops on time.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant