Skip to content

chore: allow empty commits to trigger release prs - #1386

Merged
jdx merged 1 commit into
mainfrom
codex/release-empty-commits
Sep 5, 2026
Merged

chore: allow empty commits to trigger release prs#1386
jdx merged 1 commit into
mainfrom
codex/release-empty-commits

Conversation

@jdx

@jdx jdx commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Empty fix commits triggered the release workflow but were excluded by git-cliff's crate path filters, so no release PR was created. Remove those filters from version calculation, dry-run notes, the changelog, and the PR body while retaining the explicit range from the current release tag.

Commits outside crate directories now also participate in the existing git-cliff bump and changelog rules.

Validation: on the actual v6.7.0..31c9336c history, the previous command returns v6.7.0, while the updated command returns v6.7.1 and includes the empty fix commit in the release notes. ShellCheck, bash -n, and git diff --check pass.

This PR description was generated by Codex.


Note

Medium Risk
Changes release versioning and changelog inputs for all future releases; commits outside crate directories may now trigger bumps and appear in release notes.

Overview
Release automation in tasks/release-plz no longer passes --include-path filters to git-cliff for version bumps, changelog generation, dry-run output, or the release PR body. The range stays v$cur_version..HEAD, but every conventional commit in that range can now drive a bump and show up in notes—including empty fix commits that only touch non-crate paths (e.g. workflow-only changes).

The early-exit message is reworded from “no library changes” to “no version bump” to match the broader scope.

Reviewed by Cursor Bugbot for commit e74fb58. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Release Process
    • Release notes and version updates now account for all qualifying commits since the current release, including root-level changes and empty conventional commits.
    • Releases with no applicable changes now display a more general message rather than language specific to a particular component.

Entire-Checkpoint: 01M1SJYWGDJE0ZAYF5T9961BAG
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Team

Run ID: 3dd339ac-2c79-4ad8-847b-1bb97124111d

📥 Commits

Reviewing files that changed from the base of the PR and between 31c9336 and e74fb58.

📒 Files selected for processing (1)
  • tasks/release-plz

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Release changelog generation

Layer / File(s) Summary
Use the complete release range
tasks/release-plz
Git-cliff now processes v$cur_version..HEAD without library-path filters. Dry-run output, CHANGELOG.md, and PR_BODY use the same complete range. Empty conventional commits and root-level changes can affect release notes and version bumps.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to e74fb

Release automation now includes all commits since the current release tag, allowing empty fix commits outside crate paths to trigger release PRs and appear in release notes. The change is ready to merge with no remaining concrete risk identified.

Poem

A rabbit checks the release trail
No library path can make it pale
Empty commits hop into view
Root-level changes join them too
Git-cliff writes the changelog true

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: empty commits can trigger release pull requests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jdx
jdx merged commit 753355f into main Sep 5, 2026
9 checks passed
@jdx
jdx deleted the codex/release-empty-commits branch September 5, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant