chore: allow empty commits to trigger release prs - #1386
Conversation
Entire-Checkpoint: 01M1SJYWGDJE0ZAYF5T9961BAG
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughChangesRelease changelog generation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Release automation now includes all commits since the current release tag, allowing empty fix commits outside crate paths to trigger release PRs and appear in release notes. The change is ready to merge with no remaining concrete risk identified. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Empty
fixcommits triggered the release workflow but were excluded by git-cliff's crate path filters, so no release PR was created. Remove those filters from version calculation, dry-run notes, the changelog, and the PR body while retaining the explicit range from the current release tag.Commits outside crate directories now also participate in the existing git-cliff bump and changelog rules.
Validation: on the actual
v6.7.0..31c9336chistory, the previous command returnsv6.7.0, while the updated command returnsv6.7.1and includes the empty fix commit in the release notes. ShellCheck,bash -n, andgit diff --checkpass.This PR description was generated by Codex.
Note
Medium Risk
Changes release versioning and changelog inputs for all future releases; commits outside crate directories may now trigger bumps and appear in release notes.
Overview
Release automation in
tasks/release-plzno longer passes--include-pathfilters to git-cliff for version bumps, changelog generation, dry-run output, or the release PR body. The range staysv$cur_version..HEAD, but every conventional commit in that range can now drive a bump and show up in notes—including emptyfixcommits that only touch non-crate paths (e.g. workflow-only changes).The early-exit message is reworded from “no library changes” to “no version bump” to match the broader scope.
Reviewed by Cursor Bugbot for commit e74fb58. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit