Add MDS044 horizontal-rule-style rule by jeduden · Pull Request #218 · jeduden/mdsmith

jeduden · 2026-05-02T22:26:23Z

Summary

Implements the MDS044 rule to enforce consistent horizontal rule (thematic break) formatting in Markdown documents. This rule validates delimiter style, exact length, and surrounding blank lines.

Key Changes

New rule implementation (internal/rules/horizontalrulestyle/rule.go):
- Validates thematic breaks use a consistent delimiter (-, *, or _)
- Enforces exact delimiter count (minimum 3)
- Detects and flags internal spaces in thematic breaks
- Requires blank lines before and after thematic breaks (configurable)
- Implements auto-fix to rewrite thematic breaks to canonical form and insert missing blank lines
- Blockquote-aware: blank line insertion preserves > container markers; > lines are treated as blank
Configuration support:
- style: Choose delimiter style ("dash", "asterisk", or "underscore")
- length: Set exact number of delimiters required (default: 3)
- require-blank-lines: Toggle blank line enforcement (default: true)
Comprehensive test coverage (internal/rules/horizontalrulestyle/rule_test.go):
- Tests for each delimiter style
- Tests for length validation
- Tests for internal space detection
- Tests for blank line requirements
- Tests for configuration parsing and validation
- Tests for auto-fix behavior including edge cases (adjacent thematic breaks, blockquotes, list items)
Documentation (internal/rules/MDS044-horizontal-rule-style/README.md):
- Complete rule documentation with settings table
- Multiple examples (good/bad cases)
- Auto-fix behavior description
Test fixtures:
- Good examples: default style, asterisk style, underscore style, custom length
- Bad examples: wrong delimiter, internal spaces, wrong length, missing blank lines
- Fixed examples showing expected auto-fix output
Integration:
- Registered rule in main command and integration tests
- Updated rule index and plan tracking

Claude PostToolUse Hook (`.claude/settings.json`)

This PR also adds a PostToolUse hook that automatically requests a Copilot code review after any git push. The hook:

Fires on every Bash tool call; no-ops immediately unless the command contains git push
Derives the repository name dynamically via gh repo view (no hard-coded owner/repo)
Looks up the open PR for the current branch and calls the /copilot-review-requests GitHub API endpoint
Requires gh CLI to be authenticated; silently no-ops (exits 0) if gh is unavailable or the push has no associated PR

Notable Implementation Details

Thematic breaks are identified via AST walking of *ast.ThematicBreak nodes
The splitHRLine() function preserves leading context (blockquote markers, list indentation) when fixing
Auto-fix intelligently avoids duplicate blank lines when adjacent thematic breaks are present
Rule is disabled by default (per CommonMark flexibility)

https://claude.ai/code/session_01DMrBd9zRmy8SN9yuypUVMa

Adds rule MDS044 that enforces a consistent thematic break style (dash/asterisk/underscore), exact length, and required blank lines to prevent setext heading collision. Addresses review comments from PR #205: - Fix() deduplicates adjacent blank line insertions (same pattern as blanklinearoundheadings) - ApplySettings uses settings.ToInt() for int/int64/float64 coercion - README uses proper YAML front matter and include directives - Prefix (blockquote/indent) is preserved when rewriting HR lines https://claude.ai/code/session_01DMrBd9zRmy8SN9yuypUVMa

codecov · 2026-05-02T22:27:46Z

Codecov Report

❌ Patch coverage is 96.24413% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.35%. Comparing base (dcb8061) to head (14da794).
⚠️ Report is 13 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/rules/horizontalrulestyle/rule.go	96.24%	5 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   94.33%   94.35%   +0.02%     
==========================================
  Files         137      136       -1     
  Lines       15927    15755     -172     
==========================================
- Hits        15025    14866     -159     
+ Misses        551      543       -8     
+ Partials      351      346       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Add tests for previously uncovered branches: Category(), DefaultSettings(), RequireBlankLines=false, Fix() no-op early return, splitHRLine with no delimiter, styleName underscore/dash, isBlankLine out-of-bounds, and ApplySettings error paths for non-string style, non-bool require-blank-lines, float64 length, and non-integer length. https://claude.ai/code/session_01DMrBd9zRmy8SN9yuypUVMa

Copilot

Pull request overview

Adds a new Markdown lint rule (MDS044) to enforce consistent thematic break (horizontal rule) formatting, including delimiter style, exact length, and surrounding blank lines, plus auto-fix and documentation.

Changes:

Implement MDS044 horizontal-rule-style rule with configurable style, length, and require-blank-lines, including auto-fix.
Add unit tests and rule fixtures (good/bad/fixed) plus rule documentation.
Register the rule in the CLI and integration test harness; update rule index and plan status.

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
plan/108_horizontal-rule-style.md	Marks plan tasks/acceptance criteria complete.
PLAN.md	Updates plan index to show item 108 as complete.
internal/rules/index.md	Adds MDS044 to the rule index.
internal/rules/horizontalrulestyle/rule.go	New rule implementation + settings parsing + auto-fix.
internal/rules/horizontalrulestyle/rule_test.go	New unit tests for Check/Fix/settings parsing.
internal/rules/MDS044-horizontal-rule-style/README.md	New rule documentation and examples.
internal/rules/MDS044-horizontal-rule-style/good/*.md	New “good” fixtures for multiple configurations.
internal/rules/MDS044-horizontal-rule-style/bad/*.md	New “bad” fixtures asserting expected diagnostics.
internal/rules/MDS044-horizontal-rule-style/fixed/*.md	New “fixed” fixtures asserting auto-fix output.
internal/integration/rules_test.go	Imports the new rule for integration fixture testing.
cmd/mdsmith/main.go	Imports the new rule so it’s available in the CLI.

…tion - Remove trailing newline in rule_test.go (gofmt lint failure) - isBlankLine now treats lines containing only ">" markers and whitespace (e.g. "> " or ">") as blank, preventing false-positive diagnostics for thematic breaks inside blockquotes - Fix() / collectChanges now tracks the HR line's container prefix (e.g. "> ") and inserts it when adding blank lines, so the blank line stays inside the blockquote rather than exiting it - before/after maps changed from map[int]bool to map[int]string to carry the blank-line content - Add tests for blockquote blank-line detection and prefix-preserving Fix https://claude.ai/code/session_01DMrBd9zRmy8SN9yuypUVMa

Fires after every git push, looks up the open PR for the current branch, and requests jeduden as reviewer via gh api. https://claude.ai/code/session_01DMrBd9zRmy8SN9yuypUVMa

The previous hook used `if: "Bash(git push *)"` which only matched when the Bash command started with "git push". Compound commands like "git add && git commit && git push" were missed. The hook now reads stdin JSON and greps for "git push" anywhere in the command string. https://claude.ai/code/session_01DMrBd9zRmy8SN9yuypUVMa

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.

Replace hard-coded jeduden/mdsmith repo path and jeduden reviewer with dynamically derived values. Use the /copilot-review-requests endpoint to request a Copilot code review instead of a specific human reviewer. https://claude.ai/code/session_01DMrBd9zRmy8SN9yuypUVMa

Documents that Fix() correctly inserts an empty blank line after a thematic break inside a list item. CommonMark does not require blank lines to be indented for subsequent content to remain in the list item. https://claude.ai/code/session_01DMrBd9zRmy8SN9yuypUVMa

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.

…s format lint.NewFile builds File.Lines via bytes.Split(source, "\n"), so line slices do not include trailing newline bytes. Update the manual line slice construction in isBlankLine tests to match this representation. https://claude.ai/code/session_01DMrBd9zRmy8SN9yuypUVMa

…reviewer name gh repo view fails when the remote is not github.com. Derive the owner/repo by parsing git remote get-url origin instead. Also fix the reviewer name: the correct GitHub App login is copilot-pull-request-reviewer[bot], not the non-existent /copilot-review-requests endpoint. https://claude.ai/code/session_01DMrBd9zRmy8SN9yuypUVMa

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.

…nch name $BRANCH was interpolated directly into the --jq string; branch names containing quotes or other special characters could break parsing. Pipe gh api output to a separate jq call and pass the branch via --arg so it is treated as data, not code. https://claude.ai/code/session_01DMrBd9zRmy8SN9yuypUVMa

jeduden · 2026-05-03T08:11:37Z

🔍 Merge Queue — bisecting

A larger batch failed CI. Bisection is isolating the culprit: this run tests up to 1 of 1 candidate PRs on merge-queue/batch-bisect-218-1777795882. View current bisect CI run.

Next: No action needed — you'll be notified when the culprit is isolated or this PR merges.

jeduden · 2026-05-03T08:14:42Z

✅ Merge Queue — merged

This PR landed on main via commit 713322e. CI run that validated the merge.

Next: Done — nothing more to do here.

Copilot AI review requested due to automatic review settings May 2, 2026 22:26

Copilot started reviewing on behalf of jeduden May 2, 2026 22:26 View session

jeduden mentioned this pull request May 2, 2026

Implement MDS044 horizontal-rule-style rule #205

Closed

Copilot AI reviewed May 2, 2026

View reviewed changes

Comment thread internal/rules/horizontalrulestyle/rule.go Outdated

Comment thread internal/rules/horizontalrulestyle/rule_test.go

Comment thread internal/rules/horizontalrulestyle/rule.go Outdated

claude added 2 commits May 2, 2026 22:35

Add PostToolUse hook to request code review after git push

91a8010

Fires after every git push, looks up the open PR for the current branch, and requests jeduden as reviewer via gh api. https://claude.ai/code/session_01DMrBd9zRmy8SN9yuypUVMa

Copilot AI review requested due to automatic review settings May 3, 2026 07:26

Copilot started reviewing on behalf of jeduden May 3, 2026 07:27 View session

Copilot AI reviewed May 3, 2026

View reviewed changes

Comment thread .claude/settings.json

jeduden requested a review from Copilot May 3, 2026 07:33

Copilot started reviewing on behalf of jeduden May 3, 2026 07:34 View session

Copilot AI reviewed May 3, 2026

View reviewed changes

Comment thread internal/rules/horizontalrulestyle/rule.go

Comment thread .claude/settings.json

claude added 2 commits May 3, 2026 07:38

Copilot AI review requested due to automatic review settings May 3, 2026 07:40

Copilot started reviewing on behalf of jeduden May 3, 2026 07:40 View session

Copilot AI reviewed May 3, 2026

View reviewed changes

Comment thread .claude/settings.json

Comment thread internal/rules/horizontalrulestyle/rule_test.go

jeduden requested a review from Copilot May 3, 2026 07:55

Copilot started reviewing on behalf of jeduden May 3, 2026 07:56 View session

Copilot AI reviewed May 3, 2026

View reviewed changes

Comment thread .claude/settings.json Outdated

jeduden merged commit 713322e into main May 3, 2026
11 checks passed

Conversation

jeduden commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Key Changes

Claude PostToolUse Hook (.claude/settings.json)

Notable Implementation Details

Uh oh!

codecov Bot commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

jeduden commented May 3, 2026

Uh oh!

jeduden commented May 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jeduden commented May 2, 2026 •

edited

Loading

Claude PostToolUse Hook (`.claude/settings.json`)

codecov Bot commented May 2, 2026 •

edited

Loading