Open
Conversation
to this branch. MSL
needs to specify GDAL_ROOT now. MSL
Owner
|
Although you are correctly pointing to my fork you need to adjust the branch that you are pointing to - change it to jedwards/parallel_GDAL. |
Author
|
OK. I've adjusted the "merge into" branch. |
jedwards4b
reviewed
Feb 24, 2026
Owner
jedwards4b
left a comment
jedwards4b
left a comment
There was a problem hiding this comment.
Please clean up debug print statements and remove commented code. It seems like some of the code in CMakeLists.txt is duplicated?
Author
|
OK. The issues you highlighted are resolved and committed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the GDAL test and some CMake/Makefile updates for compilation with GDAL.
The GDAL test is super simple and can be expanded easily as needed. It also include a data dir in ./tests/cunit.
The data dir holds a very simple shapefile for testing. At the moment, there is no shapefile write ability.