chore(pipeline): cleanup#2398
Merged
Merged
Conversation
lemeurherve
force-pushed
the
cleanup-pipeline
branch
from
ade99f9 to
6c89e8d
Compare
timja
reviewed
Jul 7, 2026
Comment on lines
+135
to
+136
| for (t in linuxTargets) { | ||
| def targetToBuild = t |
Member
There was a problem hiding this comment.
why not this?
Suggested change
| for (t in linuxTargets) { | |
| def targetToBuild = t | |
| for (targetToBuild in linuxTargets) { |
Member
Author
There was a problem hiding this comment.
Because otherwise all branches have the same last value of linuxTargets.
Confirmed with a replay:
timja
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is a cleanup of the pipeline to get a cleaner base to work on #2397, and as small QoL improvement for replays with all targets defined at the same place on top instead of all over the pipeline.
Changes:
Testing done
CI
Submitter checklist