Skip to content

[JENKINS-29689] always try to reuse last environment#339

Closed
guss77 wants to merge 1 commit intojenkinsci:masterfrom
guss77:patch-1
Closed

[JENKINS-29689] always try to reuse last environment#339
guss77 wants to merge 1 commit intojenkinsci:masterfrom
guss77:patch-1

Conversation

@guss77
Copy link

@guss77 guss77 commented Jul 28, 2015

Otherwise the environment may not contain important variables such as JOB_NAME.

I'm pretty sure this change is covered by existing test cases. I've also tested the change with new and existing projects, with and without "force workspace" and it looks to be working fine.

Otherwise the environment may not contain important variables such as JOB_NAME
@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@MarkEWaite
Copy link
Contributor

I can't accept the change without a test which shows the problem. Tests are confirmation of the need for the change and a safety check reducing the risk of later removal of the change. Without the test which shows the problem, there is every probability that a later maintainer will change the code back, or alter it in some other way that causes the removal of the change you want. Tests also show greater comprehension of the code and help others see the intent of the change.

@guss77
Copy link
Author

guss77 commented Jul 29, 2015

Ok, I'll try to cook something up.

@guss77
Copy link
Author

guss77 commented Aug 5, 2015

This fix is incorrect - it solves the problem in some cases, but not others (specifically there is no change in the case where the previous build has failed for whatever reason). I'm still not sure how the EnvVars get built and why sometimes vars are missing, but I'll keep digging.

Thanks for the help.

@guss77 guss77 closed this Aug 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants