[JENKINS-29796] Multiple refspecs should be matched using OR, not AND

[hannes-ucsc]

https://issues.jenkins-ci.org/browse/JENKINS-29796

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[MarkEWaite]

Could you provide a test which shows the problem? A bug fix without a test is too easy to lose when someone else submits a different change.

[KostyaSha]

if (!match) {

[hannes-ucsc]

@MarkEWaite Sure, I'll write a test. Do you agree with the general idea, though? I was a little perplexed as to why the original had AND semantics. It seemed like a deliberate decision and I'm worried I'm wasting my time because I don't see the big picture.

[MarkEWaite]

I think you're on the right track. I don't know why multiple refspecs would all be required to match. That seems counter to my expectation of the cases where I might use multiple refspecs.

[hannes-ucsc]

Added a test. The test fails on the master branch and succeeds on this one.

The tests in SCMTriggerTest are a bit wonky IMHO. For example, the commits parameter to SCMTriggerTest.check() is never used. I was also surprised to see the poll.hasChanges() assertion in check() is always false.

[MarkEWaite]

It is a complicated enough plugin that I often discover unexpected twists and turns while writing tests. That discovery process has been part of the fun of trying to maintain the plugin. Thanks for writing the test.