Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for error when job is configured with multiple remotes and branch spec is set to commit SHA1 #395

Merged
merged 2 commits into from Jun 5, 2016

Conversation

@gosuwachu
Copy link

commented Apr 28, 2016

Steps to reproduce:

  1. create a job and add git scm, with two remotes:
    /source/repo1.git
    /source/repo2.git
  2. set branch to commit SHA1 from one of the two repos
  3. build

Expected: Successful build
Actual: Failed build with error:
ERROR: Couldn't find any revision to build. Verify the repository and branch configuration for this job.

@kwridan-bb

This comment has been minimized.

Copy link

commented May 3, 2016

👍

@MarkEWaite

This comment has been minimized.

Copy link

commented Jun 4, 2016

Is there a reason you chose not to try the change proposed in #285 ?

Your proposed change passed my initial interactive testing and automated tests on multiple platforms and multiple git versions. I'll continue evaluating it as preferred over PR285

@MarkEWaite MarkEWaite merged commit c0e595c into jenkinsci:master Jun 5, 2016

1 check passed

Jenkins This pull request looks good
Details
@gosuwachu

This comment has been minimized.

Copy link
Author

commented Jun 15, 2016

#285 solved just one specific problem, not the one that I have seen.

@gosuwachu gosuwachu deleted the gosuwachu:dev/pwach/multi-remote branch Jan 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.