Use abstract decorateCheckoutCommand#422
Closed
corngood wants to merge 1 commit intojenkinsci:masterfrom
Closed
Conversation
Allows CheckoutOption to work with e.g. Pipeline tasks
Contributor
|
Would you be OK if I merged your test into PR423? Also, could you review the code change in PR423 and compare the technique there to your technique? I was trying to preserve the existing signature (and mark it as deprecated, while still fixing the JENKINS-22547 bug. |
Contributor
Author
|
Yeah, yours looks good. I'll close this one. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows CheckoutOption to work with e.g. Pipeline tasks
I'm not sure about the test. It's not actually testing GitStep, but it's very similar to the existing tests. Should it be in a new class?