using author in the changelog should not require workspace polling#583
Merged
MarkEWaite merged 1 commit intojenkinsci:masterfrom May 2, 2018
Conversation
Commit d8338ce ("[FIXED JENKINS-19001] extension can declare requirement for a workspace during polling", 2014-03-06) appears to have accidentally set the workspace to poll whenever AuthorInChangelog is used. The extension only modifies two things, (a) the changelog parser which should not depend on polling and (b) the check for user exclusion in isRevExcluded. One might consider that the second case does depend on polling, however it is only triggered in the case where the UserExclude extension is enabled! Thus, we should not need to poll when only using the AuthorInChangelog extension. It appears this functionality should already be tested by testAuthorOrComitterTrue() in GitSCMTest.java. Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
12 tasks
MarkEWaite
approved these changes
May 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit d8338ce ("[FIXED JENKINS-19001] extension can declare
requirement for a workspace during polling", 2014-03-06) appears to have
accidentally set the workspace to poll whenever AuthorInChangelog is
used.
The extension only modifies two things, (a) the changelog parser which
should not depend on polling and (b) the check for user exclusion in
isRevExcluded.
One might consider that the second case does depend on polling, however
it is only triggered in the case where the UserExclude extension is
enabled! Thus, we should not need to poll when only using the
AuthorInChangelog extension.
It appears this functionality should already be tested by
testAuthorOrComitterTrue() in GitSCMTest.java.
Signed-off-by: Jacob Keller jacob.e.keller@intel.com
JENKINS-xxxxx - summarize pull request in one line
Describe the big picture of your changes here to explain to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, include a link to the issue.
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.Types of changes
What types of changes does your code introduce? Put an
xin the boxes that applyFurther comments
I don't think new tests are required, as the functionality should be verified by existing tests. As far as I can tell, this extension forcing polling in workspace was an oversight of the commit which introduced the requirement. I'm currently in the process of doing interactive testing locally.