Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using author in the changelog should not require workspace polling #583

Conversation

Projects
None yet
2 participants
@jacob-keller
Copy link

commented Apr 23, 2018

Commit d8338ce ("[FIXED JENKINS-19001] extension can declare
requirement for a workspace during polling", 2014-03-06) appears to have
accidentally set the workspace to poll whenever AuthorInChangelog is
used.

The extension only modifies two things, (a) the changelog parser which
should not depend on polling and (b) the check for user exclusion in
isRevExcluded.

One might consider that the second case does depend on polling, however
it is only triggered in the case where the UserExclude extension is
enabled! Thus, we should not need to poll when only using the
AuthorInChangelog extension.

It appears this functionality should already be tested by
testAuthorOrComitterTrue() in GitSCMTest.java.

Signed-off-by: Jacob Keller jacob.e.keller@intel.com

JENKINS-xxxxx - summarize pull request in one line

Describe the big picture of your changes here to explain to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, include a link to the issue.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No findbugs warnings were introduced with my changes
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Further comments

I don't think new tests are required, as the functionality should be verified by existing tests. As far as I can tell, this extension forcing polling in workspace was an oversight of the commit which introduced the requirement. I'm currently in the process of doing interactive testing locally.

Jacob Keller
using author in the changelog should not require workspace polling
Commit d8338ce ("[FIXED JENKINS-19001] extension can declare
requirement for a workspace during polling", 2014-03-06) appears to have
accidentally set the workspace to poll whenever AuthorInChangelog is
used.

The extension only modifies two things, (a) the changelog parser which
should not depend on polling and (b) the check for user exclusion in
isRevExcluded.

One might consider that the second case does depend on polling, however
it is only triggered in the case where the UserExclude extension is
enabled! Thus, we should not need to poll when only using the
AuthorInChangelog extension.

It appears this functionality should already be tested by
testAuthorOrComitterTrue() in GitSCMTest.java.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>

@jacob-keller jacob-keller referenced this pull request Apr 23, 2018

Merged

don't require polling for ChangeLogToBranch #584

9 of 12 tasks complete

@MarkEWaite MarkEWaite merged commit 6cd9faf into jenkinsci:master May 2, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.