Remove -t option from fetch command

[algoRhythm99]

I've removed the -t option from the fetch command, as requested in https://issues.jenkins-ci.org/browse/JENKINS-6124.

[ghost]

This isn't fixing a bug, just a bad design decision, and it is now changing default behavior from past releases of the plugin. This should not be done in this way. It may have been wrong to fetch with -t, but we have to live with the consequences of bad decisions.

Make the -t controlled via optional parameter, and leave it on by default (maintaining the current process).

[buildhive]

Jenkins » git-plugin #40 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

[kctigerhawk]

It is not working as documented.

The documentation no where states that all tags will be fetched, and it specifically says in the help text for the refspec that nothing other than the specified refspec will be fetched.

Generally, code that does not perform as documented is a bug.

How about, if the code is modified so that if a refspec is specified the "-t" is not added otherwise it is. Then behavior would match documentation?

[kctigerhawk]

Created a new issue https://issues.jenkins-ci.org/browse/JENKINS-14572 to directly address the bug and set aside the 'bad design decision' issue for now.

[ndeloof]

documentation may be wrong, and should then be fixed, but the existing behavior must be kept for backward compatibility