Fix Jenkins-15048 - shorten build data display name#95
Merged
ndeloof merged 1 commit intojenkinsci:masterfrom Sep 10, 2012
Merged
Fix Jenkins-15048 - shorten build data display name#95ndeloof merged 1 commit intojenkinsci:masterfrom
ndeloof merged 1 commit intojenkinsci:masterfrom
Conversation
Longer display name moves crucial data off screen to the right.
|
Jenkins » git-plugin #78 SUCCESS |
ndeloof
added a commit
that referenced
this pull request
Sep 10, 2012
Fix Jenkins-15048 - shorten build data display name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most recent git plugin update (extending the BuildData object to work more effectively with the Multiple SCM plugin), inadvertently made the user interface worse.
The longer display name moves crucial data off screen to the right. This change reduces the BuildData display name back to what it was before the Multiple SCM plugin additions. It does not remove any other changes related to Multiple SCM plugin, just the length of the display name.
This submission also adds a test, though the test is of questionable value, since all it does is check that the BuildData object returns the expected display name value.
The plugin passed all tests as run by "mvn install" on my 64 bit Debian Squeeze machine with Oracle JDK 7.0.