Fix character corruption problem#98
Closed
bleis-tift wants to merge 3 commits intojenkinsci:masterfrom
Closed
Conversation
|
Jenkins » git-plugin #89 SUCCESS |
Member
There was a problem hiding this comment.
I think this test would pass on a typical Linux machine (or anything else using UTF-8 by default) without the source code change, meaning when run on ci.jenkins-ci.org or the like it would not defend against regressions. To make it a stronger test you would need to call e.g. System.setProperty("file.encoding", "ISO-8859-1") very early in test VM startup, perhaps in a static block; or even pass this system property in Surefire configuration to make sure it is set from the start.
Contributor
|
merged as cdf149a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.