Conversation
|
Jenkins » github-plugin #26 SUCCESS |
case on "GitHub" unused GitHubPushCause
|
Really interested in this feature, any idea on what is still waiting and if I can be of help? |
|
👍 very useful addition!! |
|
+1 |
[FIXED JENKINS-15045] Commit status API
|
👍 when will this be available? |
|
I think this commit is incomplete; using the commit status API requires authentication to GitHub, which requires credentials. However, credentials can only be configured in the global config page if the user is allowing the GitHub plugin to automatically manage service hooks; if manual service hook management is enabled, there is no place to configure credentials (in other words, the same credentials are now serving another purpose). I believe this can be fixed by moving the 'GitHub Credential' section of GitHubPushTrigger/global.jelly outside the radioblock section, but it might be even better to create a separate global config area for the credentials, since using them only for the commit status updates is unrelated to push triggering. |
|
This should be delegated to the credentials-plugin anyway 2013/2/15 Kevin P. Fleming notifications@github.com
|
|
Yeah, I was thinking about that this morning. That would help in another way: instead of the commit status update 'guessing' which credentials to use, the proper one could be explicitly selected. |
|
Ah right, I think this explains why when I built latest from source, I couldn't find anywhere to set the global/project config (as I don't use the github plugin managed webhooks, just polling). This may also be the cause of JENKINS-15787 |
|
Rolled back to v1.5:
Updated to latest:
Logged: I also get an unreadable data warning in the UI: hudson.model.FreeStyleProject TMS-BRANCH CannotResolveClassException: com.coravy.hudson.plugins.github.GithubProjectProperty : com.coravy.hudson.plugins.github.GithubProjectProperty |
|
That's quite strange, as the project property code hasn't been touched in a while (in fact, it isn't even used for much in the plugin right now except putting a link on the project page). I haven't populated that property on any of my projects. |
|
Any updates on when this will be available? 😊 |
|
I should mention. I have been running this at my workplace for a few weeks now. We do use the plugin to manage service hooks, so it worked fine. The only thing that is really missing to make this a solution to compete with travis-ci is pull-request hook, so that tests are run when a new pull request is opened. |
|
Any update ? We need this badly. |
|
+1 |
|
@addisonj have you seen the pull request builder plugin? https://wiki.jenkins-ci.org/display/JENKINS/Github+pull+request+builder+plugin |
|
I also tried to build the latest version of the plugin and I get the same stacktrace as dhendo. Apr 27, 2013 12:10:03 AM hudson.util.CopyOnWriteList$ConverterImpl unmarshal The strange thing is that the class in mention com.coravy.hudson.plugins.github.GithubProjectProperty is there. So, I have no idea why he can't find it. |
|
Ok, so I've got this working now:
I strongly suspect that having the latter setup correctly caused the commit status API to start working correctly. Other than the port forwarding / firewalling setup (Github IPs here: https://help.github.com/articles/what-ip-addresses-does-github-use-that-i-should-whitelist) there are no major downsides to moving to push-based. |
|
@dhendo basically I didn't get you, this feature is available in 1.6 ? |
|
@ludofleury yes, it now works fine for me in version 1.6. Setup Steps:
In your github account, setup the Jenkins hook. With this set up, builds are now triggered by pushed to github, commit SHAs are linked to github and the status of each commit is written to github. |
|
@dhendo Hey, yes I didn't notice the "Set build status on Github commit", it works like a charm, just need some documentation on it on the jenkins plugin page maybe.
gcli status create MyOrganization MyRepository $GIT_COMMIT --state="pending" --target=$BUILD_URL --desc="Build #$BUILD_NUMBER is running" --format="csv"
But, thanks you very much for your work, we needed this and it's already really handy. |
From the docs:
I don't understand how to use the API key too, it seems the password is the only option.
I have a "delete" button for this notifier, I can delete it without problems. On my install I have everything set up as it has been said, but still no luck in commit status. The only difference is that I used "Manually manage hook URLs" instead of "Let Jenkins auto-manage hook URLs" (I didn't want to leave my password in there). |
|
@mnapoli AFAIK, the commit status API needs a username and password to set the status. From what I saw, it also doesn't work if you have it set to "Manually manage hook URLs" To avoid username/password authentication, it looks like we'd need to use OAuth: https://github.com/blog/1090-github-api-moving-on |
|
@dhendo Thanks, then I know what's wrong, I'll see to change the set up. |
|
@mnapoli could you screenshot me your delete button lol. cause I don't have it ? |
|
There you go: Jenkins 1.515 (fresh install from 2 days ago) |
|
@mnapoli Damn, maybe a conflict with some other displayed plugins... don't have the button. Thanks much |
|
Apparently username/password authentication is not a option any more. Does anybody have the build status on Github working with OAuth token? |
|
Yes, I got a Personal OAuth token to use with it. Settings -> Applications -> Personal Access Tokens |
|
Ok. Then I have no idea what is going wrong in my case. I have created a access token and added that to my Jenkins settings. Jenkins says that the authentication was successful. At the end of the build I see the following message: Setting commit status on GitHub for https://github.com/peerke/OutdoorPuzzleGame/commit/599bcbcb8315bcf7f0955d1b3bbaacf9cfa2d1ce I don't see anything in the commit on GitHub. What am I doing wrong? |
14 participants
Notifier to use GitHub status API