Tightens exception handling for Github Webhooks.#40
Merged
nukulb merged 1 commit intojenkinsci:masterfrom May 1, 2014
Merged
Conversation
Checks to see if the Github Webhook request being processed is actually of type 'push' before trying to process the request payload. The structure of each type of Github Webhook differs and processing will fail. Improves exception message when payload is not found and urges the client to check the payload version on the Github Webhook to allow easier debugging.
|
plugins » github-plugin #32 SUCCESS |
Member
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
nukulb
added a commit
that referenced
this pull request
May 1, 2014
Tightens exception handling for Github Webhooks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are simply improvements so that other people have an easier time debugging their issues.