Skip to content

[JENKINS-36732] Use start time instead of scheduled time in build history.#2460

Merged
oleg-nenashev merged 1 commit intojenkinsci:masterfrom
ikedam:feature/JENKINS-36732_FixBuildHistoryTimestamps
Jul 26, 2016
Merged

[JENKINS-36732] Use start time instead of scheduled time in build history.#2460
oleg-nenashev merged 1 commit intojenkinsci:masterfrom
ikedam:feature/JENKINS-36732_FixBuildHistoryTimestamps

Conversation

@ikedam
Copy link
Member

@ikedam ikedam commented Jul 16, 2016

JENKINS-36732

There's a build

  • scheduled at 10:00
  • started at 11:00 (nodes were busy for long time)
  • finished at 11:30

Before this fix, the build history displays the build during 10:00 - 10:30.
This fix displays the build during 11:00 - 11:30 correctly.

Before this fix:
screen shot 2016-07-16 at 11 12 16

After this fix:
screen shot 2016-07-16 at 12 20 46

@oleg-nenashev
Copy link
Member

Looks reasonable for the default behavior. But I would vote for retaining the original behavior and making it available via request parameter or UI control (e.g. "Display with queue wait times")

@oleg-nenashev
Copy link
Member

Ideally, it would be great to...

  • display Queue Wait time on the chart with a different color (e.g. "blue" for build time and "blue with hatching" for queue wait time)
  • Display "Scheduling time" and "Execution started" times in the popup

@oleg-nenashev oleg-nenashev added the needs-more-reviews Complex change, which would benefit from more eyes label Jul 17, 2016
@ikedam
Copy link
Member Author

ikedam commented Jul 17, 2016

But I would vote for retaining the original behavior
it would be great to...

It might be.
But I don't plan to work for those new features. They should require so many changes.
I'd like you to take over the ticket for those new features if they're required to fix the current behavior.

@daniel-beck
Copy link
Member

👍 on this change. It's the only sensible behavior without introducing an additional wait time visualization.

The proposed option doesn't seem to make sense, as the data is simply wrong right now.

@KostyaSha
Copy link
Member

. But I would vote for retaining the original behavior

How often do you use this trend? :)

+1 for change as it Build history and not start history.

display Queue Wait time on the chart with a different color (e.g. "blue" for build time and "blue with hatching" for queue wait time)

Queue wait timing is separate plugin feature AFAIR

@oleg-nenashev
Copy link
Member

But I don't plan to work for those new features. They should require so many changes.
I'd like you to take over the ticket for those new features if they're required to fix the current behavior.

Nope, do not have time for it :(
As I said before, I'm fine with changing the default behavior. If others do not think the current layout makes sense, so let it be.

How often do you use this trend? :)

Rarely, because it's not very useful

@KostyaSha
Copy link
Member

Rarely, because it's not very useful

That's no need to spend time on it and add complexities :)

@oleg-nenashev oleg-nenashev added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback and removed needs-more-reviews Complex change, which would benefit from more eyes labels Jul 26, 2016
@oleg-nenashev oleg-nenashev merged commit 9e1d1b0 into jenkinsci:master Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants