Stage 0.1: Golden-fixture convention and regeneration tooling#440
Merged
Conversation
Establish tests/data/goldens/ with dev/regenerate_goldens.py suite registry, pipeline_smoke oracle on the canonical Arbin .res, essential regression tests, and documentation. Closes #428. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…m CI Floor summary date_time to microsecond precision before golden write and compare so Linux and Windows agree after parquet round-trip. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Exact assert_frame_equal on all columns except date_time; compare date_time as epoch-ns with 1 µs absolute tolerance to absorb cross-platform parquet drift. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Tier 1 (ci.yml) is now the uv essential job alone. Full conda pytest on Linux/macOS/Windows already lives in ci-scheduled.yml — no duplicate slow runs on every PR. Document essential-marker contract in ci-tiers.md. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/data/goldens/<suite>/as the shared home for cellpy 2 characterization oracles (parquet for frames, JSON for scalars/meta).dev/regenerate_goldens.pywith@register_golden_suiteregistration,--verifybyte-identical check, and stable parquet/JSON writers.pipeline_smokeon the canonical Arbin.res(103 steps / 18 cycles / cycle-1data_point1457) with two@pytest.mark.essentialregression tests picked up by CI Tier 1.tests/README.mdandtests/data/goldens/README.md.Closes #428
Test plan
uv run python dev/regenerate_goldens.py --verify pipeline_smokeuv run pytest tests/test_goldens.py -vuv run pytest -m essential --ignore=tests/test_plotutils_summary_plot.pyMade with Cursor