Stage 0.2: Cellpy-file HDF5 characterization tests#443
Merged
Conversation
Lock load/save behavior before the cellpy-file refactor: v8 round-trip with a fid-populated fixture, limits-prefix trap, max_cycle selector, legacy version matrix, and missing-key failure mode. Three essential tests extend the PR gate. Closes #429. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
tests/test_cellpy_file_roundtrip.py— Stage 0.2 characterization suite locking current cellpy-file (HDF5) load/save behavior before the module extraction refactor.testdata/hdf5/20160805_test001_45_cc_v8_with_fids.h5and compare helpers intests/cellpy_file_support.py.@pytest.mark.essential: v8 round-trip (full frame equality), limits-prefix trap (unprefixed limits in/CellpyData/info), andselector={"max_cycle": N}truncation.TypeError(current behavior), v0WrongFileVersion, missing HDF key exception, andcheck_file_idssmoke.Closes #429
Test plan
uv run pytest tests/test_cellpy_file_roundtrip.py -v(10 passed)uv run pytest -m essential --ignore=tests/test_plotutils_summary_plot.py(21 passed)essential (linux / uv)green on PRNotes
TypeErroron_extract_meta_from_old_cellpy_file_max_v7(missingupgrade_from_to) — tests pin that behavior for the refactor to fix deliberately.graphify-out/local rebuild left unstaged (not part of this PR).Made with Cursor