You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
…Stage 0.6)
Add committed oracles for get_cap, get_ccap, get_dcap, and get_ocv on the
canonical Arbin cell, covering labeled/interpolated/multi-cycle variants
and explicit NullData cases for missing cycles.
Co-authored-by: Cursor <cursoragent@cursor.com>
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Not approving: the essential CI check failed with 9 failures in tests/test_curve_goldens.py (path-separator mismatch in golden metrics.json source fields). Cursor Bugbot was not enabled on this PR, so automated review was skipped. Human review is needed before merge.
Sent by Cursor Approval Agent: Pull Request Router and Approver
Windows backslashes in metrics.json source paths broke Linux CI parity
checks. Normalize to forward slashes via Path.as_posix() and regenerate
curve metrics fixtures.
Co-authored-by: Cursor <cursoragent@cursor.com>
Document that path strings in committed golden JSON must use forward
slashes so Windows-generated fixtures pass Linux CI.
Co-authored-by: Cursor <cursoragent@cursor.com>
The reason will be displayed to describe this comment to others. Learn more.
Approved: essential CI passed and Cursor Bugbot is not enabled on this PR, so no automated findings block merge. No reviewers were assigned (msudars is already requested).
Sent by Cursor Approval Agent: Pull Request Router and Approver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Summary
tests/data/goldens/curve_*/for theget_capfamily on the canonical Arbin.rescell.get_cap(back-and-forth, forth-and-forth labeled, interpolated, multi-cycle),get_ccap,get_dcap,get_ocv, plusNullDatacases for missing cycles.dev/regenerate_goldens.py; 18 parametrized@pytest.mark.essentialregression tests intests/test_curve_goldens.py.Closes #433
Test plan
uv run pytest tests/test_curve_goldens.py -m essentialuv run pytest tests/test_loader_goldens.py -m essential(no regression)uv run python dev/regenerate_goldens.py curve_get_cap_back_and_forth_c1 ... curve_get_dcap_null_cycleMade with Cursor