test(testing): value-parity comparator through header mapping (Stage 0.7)#462
Merged
Conversation
…0.7) Add assert_value_parity for legacy vs native frame comparison via cellpycore.legacy.mapping, with trivial-pass essential tests on the current OldCellpyCellCore bridge (raw, steps, summary incl. specific cols). Closes #434 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Approved. Cursor Bugbot was not present on this PR, so that signal was skipped; essential CI passed and no applicable approval policies or unresolved automated findings require human review. No reviewers were assigned.
Sent by Cursor Approval Agent: Pull Request Router and Approver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/parity.py::assert_value_parity— compares legacy-named vs native-named frames throughcellpycore.legacy.mapping(raw/steps/summary, including{col}_{mode}specific summary columns), with dtype-tolerant equality and an explicitexceptionsargument..rescell proving the currentOldCellpyCellCorebridge matches the native polars engine on all mapped columns.tests/README.md; archive issue Stage 0.7: Value-parity comparator — the mapped-columns oracle harness #434 (and Stage 0.6: Curve-extraction golden snapshots (get_cap family) #433 housekeeping from init).Test plan
uv run pytest tests/test_value_parity.py -m essential— 3 passedCloses #434
Made with Cursor