Remove the deprecated easyplot module (#544)#546
Merged
Conversation
cellpy.utils.easyplot was deprecated since 1.1 (DEPRECATIONS.md) with removal scheduled for 2.0; it should not ship in the 2.0 stable. Replaced by cellpy.utils.plotutils and cellpy.utils.collectors. - delete cellpy/utils/easyplot.py, tests/test_easyplot.py, tests/integration/run_easyplot.py - drop the easyplot registration from _deprecation._seed_known_deprecations and regenerate DEPRECATIONS.md (no longer a pending deprecation) - remove test_easyplot_import_warns_once (module is gone) - docs: drop the easyplot automodule from cellpy.utils.rst, remove it from the dev folder-structure listing, and note the removal in the v1->v2 migration guide No internal code imported easyplot, so nothing else changes. Closes #544 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cellpy.utils.easyplotwas deprecated since 1.1 (registered inDEPRECATIONS.md) with removal scheduled for 2.0, and should not ship in the 2.0 stable. Replaced bycellpy.utils.plotutils+cellpy.utils.collectors.cellpy/utils/easyplot.py,tests/test_easyplot.py,tests/integration/run_easyplot.py._deprecation._seed_known_deprecationsand regenerateDEPRECATIONS.md(it's no longer a pending deprecation — the removal itself is recorded in HISTORY).test_easyplot_import_warns_once(module is gone); theDEPRECATIONS.mddoc-sync test still passes.automodulefromcellpy.utils.rst, remove it from the dev folder-structure listing, and note the removal + replacement in the v1→v2 migration guide.No internal code imported easyplot (only the deprecation registration referenced it), so nothing else changes. This also removes easyplot's ~51 curve-column references from the #540 migration surface.
Test plan
cellpy.utils.easyplotno longer importable;plotutils/collectorsimport finetest_deprecation_conventions.py: 5 passed (incl. the DEPRECATIONS.md renderer-sync test)easyplotrefs in code (only an explanatory comment in_deprecation.py)Closes #544
🤖 Generated with Claude Code