Fix BatchICACollector fig_pr_cycle KeyError on cycle_num - #684
Merged
Conversation
ICA frames use the cycle column; plotters were hardcoding cycle_num when counting and filtering for fig_pr_cycle, which crashed on v2.0.0rc1. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cycle;_cycles_plotter/sequence_plotterwere hardcodingcycle_num/.cycle, soBatchICACollector(..., plot_type="fig_pr_cycle")crashed withKeyError: 'cycle_num'on v2.0.0rc1.z); filter before thefig_pr_cyclez/gswap. Also fixcycles_plotter's too-many-cycles branch for capacity frames.fig_pr_cycle.Test plan
MPLBACKEND=Agg uv run pytest tests/test_collectors.pyMPLBACKEND=Agg uv run pytest -m essentialBatchICACollector(b, plot_type="fig_pr_cycle", cycles=[1, 2, 3])(issue repro)Closes #679
Made with Cursor