feat(batch): aggregate + qc + outputs (#701) - #731
Merged
Conversation
Fifth arc of Epic A (batch v3, #696). Unblocks Epic B (collectors consume batch.aggregate). - aggregate.combine_summaries(cells, journal): one tidy long-format frame with cell/group/sub_group key columns (replaces the wide/multiindex join machinery); cells without a summary are skipped. - qc.check(cells): the legacy _check_cell_* family (batch.py:367-456) as one function returning a tidy per-cell pass/fail frame (empty, n_raw/steps/ summary/cycles, cap stats, pass). - outputs.write_csv/write_parquet/write_excel: pure writers taking a frame + explicit path; never mkdir implicitly (that is layout.ensure_dirs). 6 tests: tidy combine + journal groups + empty; qc pass frame; writer round-trips; writers don't create dirs. Full batch-v3 suite: 34 green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jepegit
added
the
cellpy2-stage4
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A5 — batch v3:
aggregate+qc+outputsFifth arc of Epic A (batch v3, #696). Unblocks Epic B — collectors consume
batch.aggregate. Additive.aggregate.combine_summaries(cells, journal)— one tidy long-format frame withcell/group/sub_groupkey columns, replacing the wide/multiindexjoin_summariesmachinery. Cells without a summary are skipped.qc.check(cells)— the legacy_check_cell_*family (batch.py:367-456) as one function → a tidy per-cell pass/fail frame (empty,n_raw/n_steps/n_summary/n_cycles, cap stats,pass).outputs.write_csv/write_parquet/write_excel— pure writers taking a frame + explicit path; never mkdir implicitly (that'slayout.ensure_dirs).Tests —
tests/test_batch_v3_aggregate.py(6, all green)Tidy combine + journal-group mapping + empty case; QC pass frame over a real cell; writer round-trips (csv/parquet/xlsx); writers don't create dirs. Full batch-v3 suite: 34 green.
Next: A6 (#702) —
facade.py(Batch,load()/from_journal()) + golden parity vs old. Part of #696.🤖 Generated with Claude Code
Closes #701.