feat(batch): Batch facade + load/from_journal (#702) - #732
Merged
Conversation
Sixth arc of Epic A (batch v3, #696). The thin notebook-friendly Batch class tying journal (#698) + policy (#699) + runner/store (#700) + aggregate/qc (#701) together behind the surface the characterization net pinned (#697): pages, cells, summaries, update/load, combine_summaries, make_summaries, report, save, export_journal, paginate, create_journal, mark_as_bad, drop, link, recalc, plot. Module-level load()/from_journal() constructors. plot() delegates to the plotting layer via a small legacy adapter; the full tidy-frame plot path lands with the collectors redesign (Epic B). 7 tests: surface completeness, from_journal, update->summaries value parity with aggregate, report pass, mark_as_bad/drop, save round-trip, load(frame=). Full batch-v3 suite: 41 green. Closes #702. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jepegit
added
the
cellpy2-stage4
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A6 — batch v3: the
BatchfacadeSixth arc of Epic A (batch v3, #696). The thin, notebook-friendly
Batchclass that ties the package together behind the surface the characterization net (#697) pinned.cellpy/batch/facade.pyBatch—pages,cell_names,cells(lazy store),summaries/combine_summaries/make_summaries(cached, viaaggregate),update/load/recalc(viarunner.run),report(viaqc),save/export_journal,paginate(vialayout.ensure_dirs),create_journal,mark_as_bad,drop,link.load()/from_journal()— module-level constructors (file / frame / model / name).plot()delegates to the plotting layer via a small legacy adapter; the full tidy-frame plot path lands with the collectors redesign (Epic B) per batch plan §4.7.Tests —
tests/test_batch_v3_facade.py(7, all green)Surface completeness;
from_journal;update→summariesvalue parity withaggregate;reportpass;mark_as_bad/drop;saveround-trip;load(frame=). Full batch-v3 suite: 41 green.Cross-impl golden parity (old
Batchvs new) runs at A7 (#703) whenutils.batchdelegates tocellpy.batchand A1'stest_batch.pygolden exercises the new path.Closes #702. Part of #696.
🤖 Generated with Claude Code