feat(batch): process-pool + thread executors (#704) - #734
Merged
Conversation
Final arc of Epic A (batch v3, #696). Serial vs parallel is a choice of executor, not a 300-line clone (the legacy parallel_update). - runner.run(..., executor="serial"|"threads"|"processes") - all reuse load_cell. threads keep live cells (shared memory); processes return pickle-safe outcomes (no live CellpyCell across the boundary; cells re-read from files on demand, batch plan section 7 / Windows pickling). - EXECUTORS registry; unknown executor -> ValueError with the valid choices. - facade Batch.update(executor=...) threads the choice through. 3 tests: threads keep live cells + progress; processes return outcomes with cell=None; unknown executor raises. Full batch-v3 suite: 46 green. Note: deletion of the legacy parallel_update/dead stubs is E4 (breaking). Closes #704. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jepegit
added
the
cellpy2-stage4
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A8 — batch v3: parallel executors
Final arc of Epic A (batch v3, #696). Serial vs parallel is a choice of executor, not a second 300-line method (the legacy
parallel_updateclone). Additive.runner.run(..., executor="serial" | "threads" | "processes")— all reuseload_cell.threadskeep live cells (shared memory);processesreturn pickle-safe outcomes (no liveCellpyCellacross the boundary — cells re-read from files on demand; batch plan §7 / Windows pickling).EXECUTORSregistry; unknown executor →ValueErrorlisting the valid choices.Batch.update(executor=...)threads the choice through the facade.Tests (3, all green)
threadskeep live cells + fire progress;processesreturn outcomes withcell=None; unknown executor raises. Full batch-v3 suite: 46 green.Deletion of the legacy
parallel_update/dead stubs is E4 (breaking).This completes Epic A (batch v3). Closes #704. Part of #696.
🤖 Generated with Claude Code