D2: surface per-test metadata as Batch.tests (#711) - #740
Merged
Conversation
Expose the per-test TestMeta records a cell carries in Data.tests (#506) at the batch level as a tidy long-format frame: - aggregate.combine_tests(cells, journal): one row per (cell, test_id) with the native scalar TestMeta fields (cell_name, cycle_mode, test_family/type, source_type/uri, channel, creator, start/loaded datetimes, voltage limits, comment) plus cell/group/sub_group keys; raw_file_names flattened to a string; nested/object fields skipped. Empty frame when no cell has metadata. - Batch.tests property returning it; combine_tests exported from cellpy.batch. Delivered app-side without waiting on the core build_tests_summary roadmap function (which isn't in cellpycore yet) -- the per-test metadata already exists on Data.tests. Verified on a real cell and with a multi-test fake. Closes #711 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic D, arc D2 (#711) — test-level summaries in batch reports
Surfaces the per-test
TestMetarecords a cell carries inData.tests(#506) at the batch level as a tidy long-format frame.aggregate.combine_tests(cells, journal)— one row per (cell,test_id) with the native scalarTestMetafields (cell_name,cycle_mode,test_family/type,source_type/uri,channel,creator, start/loaded datetimes, voltage limits, comment) pluscell/group/sub_groupkeys.raw_file_namesflattened to a string; nested/object fields skipped. Empty frame when no cell exposes metadata.Batch.testsproperty returning it;combine_testsexported fromcellpy.batch.Note on scope
The issue referenced core
build_tests_summary(ROADMAP) — that function isn't in cellpycore yet (it exists only as a docstring example). But the per-test metadata already lives onData.tests, so this is delivered app-side with no core dependency, satisfying the acceptance (per-test summaries exposed, tidy long-format, native columns). A future corebuild_tests_summarycould enrich each row with per-test summary stats on top of this metadata surface.Verified on a real cell (1 test → 1 row) and a multi-test fake (2
test_ids → 2 rows).Closes #711