E1: remove plotting deprecation shims (#713) - #741
Merged
Conversation
Remove every plotting shim marked removal:2.1 in DEPRECATIONS.md: - interactive= (summary_plot / raw_plot / cycle_info_plot / cycles_plot / ica_plot / dva_plot) -> backend= is the only spelling. Dropped the param, the PlotConfig.interactive field, and the inline/helper resolve branches; _resolve_plot_backend is now backend-only. - cycles_plot(xlim=/ylim=) -> x_range/y_range only. - plotutils.summary_plot_legacy -> deleted (delegated to summary_plot). - Batch.plot(backend="seaborn") -> removed; seaborn and bokeh backend names now raise ValueError in resolve_batch_plot_backend (seaborn *styling* under the matplotlib backend is unaffected). Trimmed the E1 rows from the _deprecation seed and regenerated DEPRECATIONS.md. Migrated the plotting tests off the removed surface (interactive=False -> backend="matplotlib", xlim/ylim -> x_range/y_range) and converted the former "alias warns" tests into signature-based "shim removed" checks (the entry points take **kwargs, so a stray interactive= is ignored, not a TypeError). Note: the CLI setup wizard's interactive= (setup_config) is an unrelated "ask questions" flag and is untouched; mpl.py xlim/ylim are matplotlib axis kwargs, not the removed cellpy shim. Closes #713 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic E, arc E1 (#713) — remove plotting shims
Removes every plotting shim marked
removal: 2.1inDEPRECATIONS.md.Removed
interactive=onsummary_plot/raw_plot/cycle_info_plot/cycles_plot/ica_plot/dva_plot→backend=is the only spelling. Dropped the param, thePlotConfig.interactivefield, the inline resolve branches, and theinteractive/deprecation_siteargs of_resolve_plot_backend(now backend-only).cycles_plot(xlim=/ylim=)→x_range/y_rangeonly.plotutils.summary_plot_legacy→ deleted (it delegated tosummary_plot).Batch.plot(backend="seaborn")→ removed;seabornandbokehbackend names now raiseValueErrorinresolve_batch_plot_backend. (seaborn styling under the matplotlib backend is unaffected.)Trimmed the E1 rows from the
_deprecationseed and regeneratedDEPRECATIONS.md.Tests
Migrated the plotting tests off the removed surface (
interactive=False→backend="matplotlib",xlim/ylim→x_range/y_range) and converted the former "alias warns" tests into signature-based "shim removed" checks — the entry points take**kwargs, so a strayinteractive=is silently ignored rather than aTypeError, making signature inspection the correct contract. Local plotting+batch group: 156 passed, planned xfails only.Note: the CLI setup wizard's
interactive=(setup_config) is an unrelated "ask questions" flag, untouched;mpl.pyxlim/ylimare matplotlib axis kwargs, not the removed shim.Closes #713