E3 (partial): remove make_new_cell (#715) - #743
Merged
Conversation
make_new_cell was a deprecated one-liner shim over CellpyCell.vacant (removal:2.1). Deleted the function from cellpy/utils/helpers.py, dropped its _deprecation seed row + regenerated DEPRECATIONS.md, and converted its warn_once test into a "removed" check. This is the trivial, fully-unblocked half of E3; the larger headers_* attribute-access migration (~57 runtime + ~110 test sites, field-mapped to schema.*) remains under #715. Refs #715 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic E, arc E3 — partial:
make_new_cellRemoves
make_new_cell, a deprecated one-line shim overCellpyCell.vacant(removal: 2.1). This is the small, fully-unblocked half of E3, landed on its own so the bigheaders_*migration can follow separately.make_new_cellfromcellpy/utils/helpers.py._deprecationseed row + regeneratedDEPRECATIONS.md.warn_oncetest into a "removed" check.The larger E3 work — migrating
headers_normal/headers_summary/headers_step_tableattribute access (~57 runtime + ~110 test sites, field-mapped toschema.*) then deleting the properties — remains under #715 and will land as its own PR(s).Refs #715