Remove the headers_* legacy shim from CellpyCell (E3 final, #715) - #747
Merged
Conversation
The per-instance `headers_normal` / `headers_summary` / `headers_step_table` attributes were a 2.0 deprecation shim (LegacyHeaderShim) mapping legacy `*_txt` attribute access to native cellpycore column names. The runtime was migrated off the shim in 2.1 (parts 1-3, #744/#745/#746); this removes the shim itself on both the native and legacy-bridge paths per the full-removal decision. - delete `cellpy/parameters/legacy_header_shim.py` (+ its test) - drop the shim wiring block from `CellpyCell.__init__` (both branches) - drop the shim's pending-deprecation seed; regenerate DEPRECATIONS.md - migrate the remaining `c.headers_*` accesses to `c.schema.raw/steps/summary` across tests and the maccor/custom `__main__` demo blocks; legacy-only step columns (`info`) become literals, and legacy-singleton usages keep `*_txt` - rewrite the shim tests in test_cell_schema.py as a shim-removed assertion `c.schema.raw` / `c.schema.steps` / `c.schema.summary` is the replacement. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final step of E3 (#715): remove the
headers_*deprecation shim itself, now that the runtime was migrated off it in parts 1–3 (#744/#745/#746).What
The per-instance
CellpyCell.headers_normal/headers_summary/headers_step_tableattributes were a 2.0 deprecation shim (LegacyHeaderShim) resolving legacy*_txtattribute access to native cellpycore column names. This removes the shim on both the native and legacy-bridge paths (the full-removal decision).cellpy/parameters/legacy_header_shim.py(+ its test)CellpyCell.__init__DEPRECATIONS.mdc.headers_*accesses toc.schema.raw/c.schema.steps/c.schema.summaryacross tests and the maccor/custom__main__demo blocksinfo) become string literalsget_headers_normal()) usages keep their*_txtnamestest_cell_schema.pyas a single shim-removed assertionReplacement
c.schema.raw/c.schema.steps/c.schema.summary— native names on the native runtime, legacy names on the legacy bridge.Verification
headers_normalattribute no longer exists on a cell; 227 tests across the affected suites (readers, roundtrip, schema, slim, bdf, plotutils, batmo, cv_partition, native_schema) pass locally withMPLBACKEND=Agg.Closes #715
🤖 Generated with Claude Code