Skip to content

Fix batch-summary benchmark: use native combine_summaries, drop xfail - #749

Merged
jepegit merged 1 commit into
masterfrom
fix-batch-summary-benchmark
Jul 27, 2026
Merged

Fix batch-summary benchmark: use native combine_summaries, drop xfail#749
jepegit merged 1 commit into
masterfrom
fix-batch-summary-benchmark

Conversation

@jepegit

@jepegit jepegit commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Problem

The benchmark CI check fails with:

missing benchmark 'test_benchmark_batch_summary_collection' in current run

test_benchmark_batch_summary_collection was xfailed pending the Epic C polars migration, still calling the old pandas helpers.concat_summaries — which now raises AttributeError: 'DataFrame' object has no attribute 'index' on the polars summary frames. An xfailed benchmark records no result, so check_baseline.py sees it absent from the current run and fails (it treats a baseline benchmark missing from the run as a regression).

Fix

Epic B/C is done, so this does what the xfail note said to do "then": migrate the benchmark to the native collector pathBatch.combine_summaries()cellpy.batch.combine_summaries (returns a polars frame) — and remove the xfail. The benchmark runs and records a result again.

Verification

  • pytest benchmarks/test_performance.py::test_benchmark_batch_summary_collection --benchmark-only1 passed (was 1 xfailed).
  • Local mean ≈ 1.19× the committed ubuntu baseline — under the +20% warn line and far under the +100% hard-fail line, so check_baseline.py no longer reports it missing. The committed baseline value can be refreshed on CI when convenient (it was captured against the old pandas path).

🤖 Generated with Claude Code

`test_benchmark_batch_summary_collection` was xfailed pending the Epic C polars
migration, calling the old pandas `helpers.concat_summaries` (which now raises
`AttributeError: 'DataFrame' object has no attribute 'index'` on polars summary
frames). An xfailed benchmark records no result, so `check_baseline.py` reports
`missing benchmark 'test_benchmark_batch_summary_collection' in current run`
and the benchmark CI check fails.

Epic B/C is done, so this migrates the benchmark to the native collector path
(`Batch.combine_summaries` -> `cellpy.batch.combine_summaries`, returning a
polars frame) and removes the xfail. The benchmark now runs and records a
result again; local mean is ~1.19x the committed baseline (well within the
+100% fail band — the baseline can be refreshed on CI when convenient).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@cursor

cursor Bot commented Jul 27, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@jepegit
jepegit enabled auto-merge (squash) July 27, 2026 20:43
@jepegit
jepegit merged commit 6877093 into master Jul 27, 2026
6 checks passed
@jepegit
jepegit deleted the fix-batch-summary-benchmark branch July 27, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant