test: remove dead fixture references from fdv.py (#655) - #759
Merged
Conversation
Audit for #655 (H2) found ~a dozen fdv.py entries pointing at fixture files that were never committed and are referenced by no test — dead inventory that makes planners re-derive what actually exists. Remove the unused references (verified unused repo-wide): - never-committed protocol .res: full_cell / constant_voltage_cell / taper_cell / gitt_cell - unused derived-oracle .h5 paths: mcc_cellpy_file_*2, pec_cellpy_file_*, nw_nda_cellpy_file_* - broken custom_data_002.csv refs + their unused instrument pairs (custom_file_paths_2/_3, custom_instrument_2/_3; only the .xlsx exists) - batch_file_dir (dir absent, unreferenced) Kept: template_dir / examples_dir / default_prm_file and the maccor/ biologics oracle paths — their consuming tests tolerate absence (create from raw or skip) and pass in CI. Added a comment clarifying that the gitt_file proxy (20210210_FC.h5) is GITT-shaped usteps, not real GITT typing (real GITT raw deferred to #655 Phase 2). Pure dead-code removal; test collection unchanged (1462 collected). Part of #655. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
First slice of the #655 (H2) fixture audit —
fdv.pyhygiene. Removes ~a dozenfdv.pyentries that point at fixture files which were never committed and are referenced by no test.Why
The audit found the "missing fixtures" in
fdv.pyare mostly dead references, not broken tests — the suite passes in CI because these symbols are simply unused. Dead inventory forces every future planner to re-derive what actually exists on disk.Removed (all verified unused repo-wide —
grepon symbol acrosstests/ cellpy/ dev/).res:full_cell/constant_voltage_cell/taper_cell/gitt_cell.h5paths:mcc_cellpy_file_*2,pec_cellpy_file_*,nw_nda_cellpy_file_*custom_data_002.csvrefs + their unused instrument pairs (custom_file_paths_2/_3,custom_instrument_2/_3— only the.xlsxexists)batch_file_dir(dir absent, unreferenced)Kept
template_dir/examples_dir/default_prm_fileand the maccor/biologics oracle paths — their consuming tests tolerate absence (create-from-raw or skip) and pass in CI. Added a comment clarifying thegitt_fileproxy (20210210_FC.h5) is GITT-shaped usteps, not real GITT typing (real GITT raw deferred to Phase 2).Verification
Pure dead-code removal.
python tests/fdv.pyimports clean;pytest --co -qcollects 1462 tests with no import/collection errors (unchanged).Part of #655 (Phase 1, slice 1 of 3).
🤖 Generated with Claude Code