test: add loader goldens for biologics / batmo / arbin_sql_h5 (#655) - #760
Merged
Conversation
The loader e2e parity matrix (#655 audit) had goldens for 5 of 9 loaders; biologics_mpr, batmo_bdf, and arbin_sql_h5 had raw sources committed in testdata/ but no regression oracle. Add their golden suites (raw.parquet + raw_units/meta/metrics json), generated via the existing spec-driven dev/regenerate_goldens.py path. - 3 new LoaderGoldenSpec entries in tests/loader_golden_support.py - goldens under tests/data/goldens/loader_{biologics_mpr,batmo_bdf, arbin_sql_h5}/ (23561x47, 21206x13, 47x16 rows x cols) - README suite table updated neware_nda is intentionally deferred: its fastnda backend isn't in the test env, so the snapshot can't be generated here (noted in the specs; #655 Phase 2). The remaining SQL-live variants stay declarations-only. Verified: --verify byte-identical across two runs for all three; the 12 new test_loader_goldens cases (raw / raw_units / meta / metrics x 3) pass. test_loader_goldens auto-skips any suite whose artifacts or loader deps are absent, so this is CI-safe. Part of #655. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
jepegit
enabled auto-merge (squash)
July 28, 2026 10:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Second slice of #655 (H2). Extends the loader golden matrix from 5/9 to 8/9 — adds regression oracles for three loaders whose raw sources were already committed but had no golden:
biologics_mpr,batmo_bdf,arbin_sql_h5.How
The golden system is spec-driven (
LOADER_GOLDEN_SPECSintests/loader_golden_support.py) andtests/test_loader_goldens.pyauto-discovers + auto-skips suites whose artifacts or loader deps are absent — so this is CI-safe regardless of optional dependencies.LoaderGoldenSpecentriestests/data/goldens/loader_{biologics_mpr,batmo_bdf,arbin_sql_h5}/(raw.parquet+raw_units/meta/metrics.json)loader_biologics_mprloader_batmo_bdfloader_arbin_sql_h5Deferred
neware_ndais intentionally left out — itsfastndabackend isn't in the test env, so the snapshot can't be generated here. Noted inline in the specs; belongs to #655 Phase 2 (generate where fastnda is installed). The SQL-live variants (arbin_sql,arbin_sql_csv/xlsx,neware_xlsx) stay declarations-only.Verification
dev/regenerate_goldens.py <suite> --verify→ byte-identical across two runs for all three.pytest tests/test_loader_goldens.py -k "biologics or batmo or arbin_sql_h5"→ 12 passed (raw / raw_units / meta / metrics × 3).Part of #655 (Phase 1, slice 2 of 3).
🤖 Generated with Claude Code