App-friendly collected figures: theme / label / height hooks (#801) - #808
Merged
Merged
Conversation
Track theme/label/height hooks for collected_plot under issue-flow before implementation. Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
Expose plotly_template, layout_updates, and height_per_panel on the collected summary path; default pretty facet labels so apps need not restyle variable= strips. Keep y_ranges working with the new labels. Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
Record the collected-figure app chrome hooks in Unreleased and move the issue-flow group to solved. Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #801: first-class app chrome knobs on collected Plotly summary figures so GUIs/notebooks can drop figures in without a private restyle pass.
Public surface (
Collection.plot/collected_plot/summary_plotter)plotly_template=— override hardcodedplotly+{method}layout_updates=— shallowfig.update_layout(**…)after collector stylingvariable=…strip;y_label_mapper=overrides)height_per_panel=— clearer alias ofsub_fig_min_height(summary default 300 px/panel)Also applies
y_rangesbefore label cleanup so #804 keeps working with pretty labels.Docs / tests
.issueflows/04-designs-and-guides/plotting-collected.mdtests/test_collected_app_hooks.py; adjustedtests/test_collected_summary_axes.pyHISTORY.mdUnreleased bulletCloses #801
Test plan
MPLBACKEND=Agg uv run pytest tests/test_collected_app_hooks.py tests/test_collected_summary_axes.py -q(14 passed)MPLBACKEND=Agg uv run pytest -m essential(635 passed locally)