fix(batch): AUTO prefer cellpy, NEWEST, force_recalc, skip redundant save - #826
Merged
Conversation
Dogfooding after #822 showed AUTO still statting remote raw files, force_recalc was a no-op for summary C-rates, and persist rewrote already-loaded .cellpy files. Prefer existing local cellpy in AUTO, add NEWEST for freshness checks, remake steps+summary on recalc, and skip redundant cellpy rewrites. Closes #825 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SourcePreference.AUTOloads an existing local.cellpywithout a remote FID check; newNEWESTkeeps the old freshness comparison.force_recalcremakes the step table and summary after load (summary C-rates come from steps)..cellpyunlessNEWEST/recalc.nom_cap_specificsis forwarded intocellpy.get.Test plan
uv run pytest -m essentialjournal_file=...,force_cellpy=True,force_recalc=Trueand confirm C-rates ~0.05–1Closes #825
Refs #822
Made with Cursor