Fix: ICA collected plot direction for line layouts + both (#821) - #835
Merged
Conversation
Track collected ICA line-layout direction filtering and direction='both' under .issueflows before implementation. Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
Filter half-cycles for fig_pr_cell/fig_pr_cycle (not only film), allow direction='both' with Plotly line_dash so lobes do not join, and warn instead of print on invalid direction values. Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
Record the ICA collected direction fix in HISTORY, register essential tests, and archive the issue-flow group as done. Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Collected ICA line plots (
layout="per_cell") ignoreddirection(onlyfilmfiltered), andica_plottersilently coerceddirection="both"to charge viaprint.Changes
_select_direction("both")leaves the frame unchanged; charge/discharge filter as before.sequence_plotterapplies direction filtering forfig_pr_cell/fig_pr_cycleas well as film.ica_plotteracceptscharge/discharge/both; invalid values log a warning and coerce to charge.both: setline_dashby direction so half-cycles do not join.ica_plotteracceptscycles=forwarded fromcollected_plotwithout clashing withcycles=.tests/test_collected_ica_direction.py; note inplotting-collected.md;HISTORY.mdUnreleased bullet.Test plan
MPLBACKEND=Agg uv run pytest tests/test_collected_ica_direction.py -q— 6 passedMPLBACKEND=Agg uv run pytest -m essential -q— 665 passedCloses #821.